Skip to content

Make videos on the computer you already own. FreeVideo runs MiniMax H3 in as little as 8 GB of VRAM and 16 GB of RAM, and adapts its acceleration path to your hardware.

Record Agent generation polling in diagnostic reports

Bowen Xued2943da85c70
diff --git a/freevideo_engine/agent/jobs.py b/freevideo_engine/agent/jobs.py
index 3937f3b..1243662 100644
--- a/freevideo_engine/agent/jobs.py
+++ b/freevideo_engine/agent/jobs.py
@@ -1788,26 +1788,94 @@ class Jobs:
def poll_generation(self, row):
prompt_id, node = row['comfy']['prompt_id'], row['comfy']['node']
state = self.port.prompt_state(prompt_id)
+ polled_at = self.clock()
if state == 'running' and row['status'] == 'queued':
self.touch(row, status='running', started_at=self.clock())
+ history = None if state in ('running', 'pending') else self.port.history(prompt_id)
+ status = (history or {}).get('status') or {}
+ outputs = ((history or {}).get('outputs') or {}).get(node) or {}
+ summary = (outputs.get('freevideo_summary') or [None])[0]
+ diagnostics = row.setdefault('generation_poll_diagnostics', dict(count=0))
+ previous = diagnostics.get('last')
+ previous_state = tuple(previous.get(key) for key in
+ ('queue_state', 'history_entry', 'history_success', 'freevideo_summary')) if isinstance(previous, dict) else None
+ registered_before = diagnostics.get('video_registered_at')
+ diagnostics['count'] += 1
+ diagnostics['last'] = dict(time=polled_at, queue_state=state,
+ history_entry=history is not None, history_success=status.get('status_str') == 'success',
+ freevideo_summary=bool(summary))
+ video = summary.get('video') if isinstance(summary, dict) else None
+ if not isinstance(video, str):
+ for entries in outputs.values():
+ for entry in entries if isinstance(entries, list) else ():
+ if not isinstance(entry, dict) or not isinstance(entry.get('filename'), str):
+ continue
+ candidate = '/'.join(part for part in (entry.get('subfolder'), entry['filename']) if part)
+ if candidate.startswith('FreeVideo/'):
+ video = candidate
+ break
+ if video:
+ break
+ if isinstance(video, str) and not diagnostics.get('video_registered_at'):
+ try:
+ if self.saved_video(video):
+ diagnostics['video_registered_at'] = polled_at
+ except (OSError, JobError, TypeError, ValueError):
+ pass
+ current_state = tuple(diagnostics['last'][key] for key in
+ ('queue_state', 'history_entry', 'history_success', 'freevideo_summary'))
+ changed = (previous_state != current_state or
+ registered_before != diagnostics.get('video_registered_at'))
+ now = polled_at
+ due = now - row.get('_generation_poll_saved_at', float('-inf')) >= 60
+ should_publish = changed or due
+ if should_publish:
+ self.save(row)
+ row['_generation_poll_saved_at'] = now
if state in ('running', 'pending'):
+ if should_publish:
+ self.publish_generation_diagnostics(row, node)
return
- history = self.port.history(prompt_id)
if history is None:
if state == 'missing' and self.clock() - row.get('queued_at', row['updated_at']) > 10:
self.finish(row, 'cancelled' if row.get('_cancel') else 'failed',
error=dict(code='cancelled' if row.get('_cancel') else 'lost',
message='The request left the ComfyUI queue without a result'))
+ if should_publish:
+ self.publish_generation_diagnostics(row, node)
return
- status = history.get('status') or {}
- outputs = (history.get('outputs') or {}).get(node) or {}
- summary = (outputs.get('freevideo_summary') or [None])[0]
if status.get('status_str') == 'success' and summary:
self.finish(row, 'succeeded', result=self.generation_result(row, summary))
+ if should_publish:
+ self.publish_generation_diagnostics(row, node)
return
if status.get('completed') is False or status.get('status_str') == 'error' or not summary:
error = self.port.generation_error(history, node)
self.finish(row, 'cancelled' if error['code'] == 'cancelled' else 'failed', error=error)
+ if should_publish:
+ self.publish_generation_diagnostics(row, node)
+
+ def publish_generation_diagnostics(self, row, node):
+ if not hasattr(self.port, 'run_output'):
+ return
+ try:
+ output = self.port.run_output(node)
+ if output is None:
+ return
+ path = Path(output).parent / 'agent-generation-poll.json'
+ value = dict(agent_generation_jobs=[dict(id=job['id'], status=job['status'],
+ video_registered_at=job.get('generation_poll_diagnostics', {}).get('video_registered_at'),
+ generation_poll_diagnostics=job.get('generation_poll_diagnostics'))
+ for job in self.jobs.values() if job.get('kind') == 'generate'
+ and job.get('generation_poll_diagnostics')])
+ temporary = path.with_name(path.name + '.' + uuid.uuid4().hex + '.tmp')
+ try:
+ temporary.write_text(json.dumps(value, allow_nan=False), encoding='utf-8')
+ os.replace(temporary, path)
+ finally:
+ temporary.unlink(missing_ok=True)
+ except (OSError, TypeError, ValueError, AttributeError):
+ return
def generation_result(self, row, summary):
spec = row['spec']
diff --git a/freevideo_engine/diagnostics.py b/freevideo_engine/diagnostics.py
index b33fa14..48df0e7 100644
--- a/freevideo_engine/diagnostics.py
+++ b/freevideo_engine/diagnostics.py
@@ -191,7 +191,7 @@ def report_files(directory):
if name in NAMES or name.endswith(('.log', '.jsonl', '.request.json', '.debug.json',
'.encoding.json', '.engine.json', '.memory.json',
'.gpu.json', '.sampling-memory.json', '.comfy-request.json',
- 'comfy-request.json')):
+ 'comfy-request.json', 'agent-generation-poll.json')):
yield Path(current) / name
diff --git a/freevideo_engine/support_report.py b/freevideo_engine/support_report.py
index 6f3f665..5211703 100644
--- a/freevideo_engine/support_report.py
+++ b/freevideo_engine/support_report.py
@@ -14,6 +14,26 @@ from .diagnostics import Redactor, is_link, read_bounded
from .diagnostic_resources import kernel_receipt
from .monitoring import save
+AGENT_VIDEO_STALL_SECONDS = 180
+
+
+def agent_video_stalls(rows, *, now=None):
+ now = time.time() if now is None else now
+ result = []
+ for row in rows if isinstance(rows, list) else ():
+ if not isinstance(row, dict) or row.get('status') != 'running':
+ continue
+ registered = row.get('video_registered_at')
+ diagnostics = mapping(row.get('generation_poll_diagnostics'))
+ last = mapping(diagnostics.get('last'))
+ if (type(registered) not in (int, float) or now - registered < AGENT_VIDEO_STALL_SECONDS
+ or not isinstance(row.get('id'), str) or not last):
+ continue
+ result.append(dict(task_id=row['id'], status='running', video_registered_at=registered,
+ last_poll={key: last.get(key) for key in ('time', 'queue_state', 'history_entry',
+ 'history_success', 'freevideo_summary')}, poll_count=diagnostics.get('count')))
+ return result
+
def number(value):
return value if type(value) in (int, float) and math.isfinite(value) and value >= 0 else None
@@ -380,6 +400,7 @@ def write(output, report=None, bridge=None, *, _retry=None, live=False, restarte
exception=latest.get('exception', []), gpu=latest or mapping(encoding.get('gpu')),
memory=mapping(last_stage.get('memory'))))
bridge = mapping(bridge) or read_json('comfy-request', output.parent / 'comfy-request.json')
+ agent_poll = read_json('agent-generation-poll', output.parent / 'agent-generation-poll.json')
redactor = Redactor([(str(output.parent), '<RUN>')])
try:
redactor.replacements.append((str(Path.home()), '<HOME>'))
@@ -482,6 +503,10 @@ def write(output, report=None, bridge=None, *, _retry=None, live=False, restarte
'Cached encoder receipts do not describe this request’s peak.'),
bridge={k:bridge[k] for k in ('status', 'error', 'bridge_seconds', 'bridge_wall_seconds', 'sampling_cache_install', 'encoder_prewarm') if k in bridge},
collection_notes=notes, log_tails={})
+ stalled = agent_video_stalls(bridge.get('agent_generation_jobs') or
+ agent_poll.get('agent_generation_jobs'))
+ if stalled:
+ payload['agent_generation_stalls'] = stalled
try:
if preview:
previous, previous_engine, previous_encoding = preview