Garry's Opinionated OpenClaw/Hermes Agent Brain
TypeScript
Test the effect index restore against plumbing commits and a held push
garrytan01fddd934865
diff --git a/test/effect-git-failed-commit-unstages-gst2128.test.ts b/test/effect-git-failed-commit-unstages-gst2128.test.tsindex b20288ed7a..eb7de7f45d 100644--- a/test/effect-git-failed-commit-unstages-gst2128.test.ts+++ b/test/effect-git-failed-commit-unstages-gst2128.test.ts@@ -133,7 +133,8 @@ test('a group step that throws after the add leaves no staged paths', async () =test('a commit that lands but reports a failure is not reversed in the index', async () => {const { top, root } = checkout();- const path = failingGit(has(' commit '));+ // The effect commit lands when update-ref moves the branch; this one moves it and still exits 1.+ const path = failingGit(has(' update-ref '));writeFileSync(join(root, 'people', 'alice-example.md'), 'Alice, second version.\n');const results = await withEnv({ PATH: path }, () => commitGitTargets(root, ['people/alice-example.md']));expect(results.get('people/alice-example.md')).toMatchObject({ code: 'git_unavailable' });diff --git a/test/effect-retry-already-committed-gst2128.test.ts b/test/effect-retry-already-committed-gst2128.test.tsindex 1e6b91a622..c4b3099e66 100644--- a/test/effect-retry-already-committed-gst2128.test.ts+++ b/test/effect-retry-already-committed-gst2128.test.ts@@ -118,3 +118,19 @@ test('one retried target tracked under a folder an ignore rule now covers does nexpect((await gitAsync(root, 'status', '--porcelain')).trim()).toBe('');expect((await gitAsync(remote, 'rev-parse', 'main')).trim()).toBe((await gitAsync(root, 'rev-parse', 'HEAD')).trim());}), 120_000);++test('a push the secret scan holds keeps the effect commit standing and leaves nothing staged', isolated(async () => {+ const { root, remote, sourceId } = await claimedRepo('scan');+ const tip = (await gitAsync(remote, 'rev-parse', 'main')).trim();+ // A script's plain commit below the effect's adds a value that looks like a token, so the effect's push is held.+ mkdirSync(join(root, 'notes')); writeFileSync(join(root, 'notes', 'script.md'), `token: ghp_${'Zt4q'.repeat(9)}\n`);+ await gitAsync(root, 'add', 'notes/script.md'); await gitAsync(root, 'commit', '-q', '-m', 'A script commit');+ const w = await write(root, sourceId, 'people/alice-example');+ await retryParkedEffects(engine, sourceId, w.requestId, false);+ await runEffects();+ const [held] = await engine.executeRaw<{ data: { parked?: { error_code: string }[] } }>("SELECT data FROM persistence_effects WHERE request_id=$1::uuid AND kind='git'", [w.id]);+ expect(held!.data.parked).toEqual([expect.objectContaining({ error_code: 'publish_secret_found' })]);+ expect(await gitAsync(root, 'show', 'HEAD:people/alice-example.md')).toContain('After');+ expect((await gitAsync(root, 'status', '--porcelain')).trim()).toBe('');+ expect((await gitAsync(remote, 'rev-parse', 'main')).trim()).toBe(tip);+}), 120_000);