Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

Classify memory_propose in the operation lists that enumerate every tool

garrytan0fe6cc65ec47
diff --git a/docs/TOOL_CATALOG.md b/docs/TOOL_CATALOG.md
index 470be9454a..a1e35721b2 100644
--- a/docs/TOOL_CATALOG.md
+++ b/docs/TOOL_CATALOG.md
@@ -4,7 +4,7 @@
<!-- Regenerate: bun run scripts/generate-tool-catalog.ts -->
<!-- Freshness-guarded by scripts/check-tool-catalog-fresh.sh (bun run verify). -->
-Every non-localOnly operation on the MCP surface: 172 tools across 27 areas. **Starter** marks membership in the ~41-op `starter` surface (`src/mcp/surface.ts`); **Gate** names the config key that must be true before remote callers see/call the op (`gbrain config set <key> true`). What a given token actually sees is further filtered per request by scope, bound-client fence, publish gates, and the per-client surface — see `docs/operations/mcp-surface-runbook.md`. Area names are non-contractual groupings.
+Every non-localOnly operation on the MCP surface: 172 tools across 26 areas. **Starter** marks membership in the ~41-op `starter` surface (`src/mcp/surface.ts`); **Gate** names the config key that must be true before remote callers see/call the op (`gbrain config set <key> true`). What a given token actually sees is further filtered per request by scope, bound-client fence, publish gates, and the per-client surface — see `docs/operations/mcp-surface-runbook.md`. Area names are non-contractual groupings.
## admin
@@ -147,6 +147,7 @@ Every non-localOnly operation on the MCP surface: 172 tools across 27 areas. **S
| `confirm_memory` | Owner only: mark a fact, take or page as confirmed by the user (trust tier user_confirmed). | write | | |
| `extract_facts` | Extract personal-knowledge facts (events, preferences, commitments, beliefs, ideas, and plain facts) from a conversation turn into the per-source hot memory. | write | | |
| `forget_fact` | Forget a fact by recording a durable withdrawal in its source and visibility. | write | | |
+| `memory_propose` | Propose one timeline entry or link on a shared page for the person this call serves; the brain owner approves it before it is written. | write | | |
| `memory_recall` | Facts for the person this call serves, one per line: their own recent facts first, then facts matching query. | read | | |
| `memory_write` | Save facts for the person this call serves, readable by them alone. | write | | |
@@ -179,12 +180,6 @@ Every non-localOnly operation on the MCP surface: 172 tools across 27 areas. **S
| `ontology_get` | Life Chronicle: the current resolved per-entity ontology (dimension → value) at `asof` (default now), with provenance + confidence + validity. | read | | |
| `ontology_propose` | Life Chronicle: record one ontology observation (entity has dimension=value), sourced + confidence-weighted + bi-temporal. | write | | |
-## other
-
-| Tool | Description | Scope | Starter | Gate |
-|---|---|---|---|---|
-| `memory_propose` | Propose one timeline entry or link on a shared page for the person this call serves; the brain owner approves it before it is written. | write | | |
-
## pages
| Tool | Description | Scope | Starter | Gate |
diff --git a/src/core/operation-load.ts b/src/core/operation-load.ts
index 1696485200..8d9eabcdef 100644
--- a/src/core/operation-load.ts
+++ b/src/core/operation-load.ts
@@ -90,7 +90,7 @@ const OP_AREAS: Record<string, string> = {
takes_scorecard: 'takes', takes_calibration: 'takes',
// hot memory (facts)
extract_facts: 'memory', forget_fact: 'memory', confirm_memory: 'memory',
- memory_recall: 'memory', memory_write: 'memory', // GST-359: QM's memory provider pair
+ memory_recall: 'memory', memory_write: 'memory', memory_propose: 'memory', // GST-359: QM's memory provider pair
// entity extraction lane
extract_entities: 'entities', extraction_pending: 'entities',
extraction_review: 'entities',
diff --git a/src/core/operation-manifest.generated.ts b/src/core/operation-manifest.generated.ts
index cbbf40fa88..b9b743643a 100644
--- a/src/core/operation-manifest.generated.ts
+++ b/src/core/operation-manifest.generated.ts
@@ -6656,7 +6656,8 @@ export const OPERATION_MANIFEST: OperationMeta[] = [
"annotations": {
"title": "memory_propose (QM proposed write)",
"idempotentHint": true
- }
+ },
+ "area": "memory"
},
{
"name": "get_memory_settings",
diff --git a/test/cli-flag-equals.test.ts b/test/cli-flag-equals.test.ts
index 631618af1d..ff3403176a 100644
--- a/test/cli-flag-equals.test.ts
+++ b/test/cli-flag-equals.test.ts
@@ -429,6 +429,7 @@ describe('#7619 split rules', () => {
'src/commands/auth-binding.ts': 'the entry refuses --member=/--may-act-for= on auth (no EQUALS_READERS key); takeBindingFlags also reads the = form so a direct caller never drops a binding',
'src/core/workspace-push.ts': 'git child argv',
'src/core/access/policy-git.ts': 'git child argv',
+ 'src/commands/memory-proposals.ts': ['memory-proposals list', 'memory-proposals deny'],
'src/commands/access-rules.ts': 'access has no EQUALS_READERS key, so the entry refuses every = form on access rule; flag() also reads it for a direct caller',
'src/core/context/session-speaker.ts': 'reads another process\'s argv (claude --print=), not a gbrain flag',
'src/eval/longmemeval/via-operation.ts': 'git child argv',
diff --git a/test/persistence-consumer-idle.test.ts b/test/persistence-consumer-idle.test.ts
index 7df52dfd64..f895fc7440 100644
--- a/test/persistence-consumer-idle.test.ts
+++ b/test/persistence-consumer-idle.test.ts
@@ -93,12 +93,25 @@ test('idle polling backs off to the cap, then a wake runs a full tick immediatel
const consumer = new PersistenceConsumer(proxy, { engine: 'pglite' }, async () => { throw new Error('no work expected'); },
{ hostId: config.hostId, pollMs: 20, idleMaxMs: 160, onError: () => {} });
const refreshes = () => statements.filter(sql => sql.startsWith('SELECT brain_id,enabled,')).length;
+ const bare = counting(engine);
+ const withoutPass = new PersistenceConsumer(bare.proxy, { engine: 'pglite' }, async () => { throw new Error('no work expected'); },
+ { hostId: config.hostId, onError: () => {} });
+ (withoutPass as unknown as { nextMaintenance: number }).nextMaintenance = Number.POSITIVE_INFINITY;
+ try { await withoutPass.tick(); await settled(withoutPass); } finally { await withoutPass.stop(); }
+ const ticks: Promise<void>[] = [];
+ const tick = consumer.tick.bind(consumer);
+ consumer.tick = (afterProgress?: boolean) => { const run = tick(afterProgress); ticks.push(run); return run; };
consumer.start();
try {
+ await waitFor(() => ticks.length > 0, { timeoutMs: 1_000 });
+ await ticks[0];
+ await settled(consumer);
+ const firstTick = statements.length;
+ // The first full tick carries the maintenance pass; a statement added to that pass changes this count on purpose.
+ expect(firstTick - bare.statements.length).toBe(8);
await Bun.sleep(2_000);
// 20 ms polling for 2 s would be ~100 ticks; doubling to a 160 ms cap is ~15.
- const ticks = statements.length;
- expect(ticks).toBeLessThan(40);
+ expect(statements.length - firstTick).toBeLessThan(40);
const full = refreshes();
consumer.wake();
await waitFor(() => refreshes() > full, { timeoutMs: 1_000 });
diff --git a/test/remote-privacy-sweep.test.ts b/test/remote-privacy-sweep.test.ts
index 6157dbcb95..a26caa544e 100644
--- a/test/remote-privacy-sweep.test.ts
+++ b/test/remote-privacy-sweep.test.ts
@@ -166,6 +166,7 @@ const PARAM_FACTORY: Record<string, Record<string, unknown>> = {
recall: { entity: WORLD_PAGE_SLUG },
memory_recall: { query: WORLD.fact },
memory_write: { facts: [{ fact: 'fresh sweep fact', provenance: 'sweep' }], idempotency_key: 'sweep-key' },
+ memory_propose: { kind: 'timeline', target: WORLD_PAGE_SLUG, date: '2026-01-01', summary: 'sweep proposal', idempotency_key: 'sweep-propose-key' },
entity: { name: WORLD_PAGE_SLUG },
synthesize: { entity: WORLD_PAGE_SLUG },
delta: { since: SINCE_EPOCH },
@@ -371,6 +372,8 @@ const EXPECTED_OUTCOME: Record<string, Outcome> = {
remember: 'ok',
// GST-359 D: memory_write saves only as an attested person; the sweep's callers attest none (actor_required).
memory_write: 'error',
+ // memory_propose also needs an attested person; the sweep's callers attest none (actor_required).
+ memory_propose: 'error',
forget: 'error',
purge_fact: 'error',
list_page_purges: 'error',