Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

remember: test the stdio member writeback rule directly and register the new suites with CI's guards (GST-2243)

garrytan1f32812fc5e9
diff --git a/src/core/snapshot-schema-inputs.ts b/src/core/snapshot-schema-inputs.ts
index b167a8405f..1a121d9db7 100644
--- a/src/core/snapshot-schema-inputs.ts
+++ b/src/core/snapshot-schema-inputs.ts
@@ -48,6 +48,7 @@ export const SNAPSHOT_DYNAMIC_IMPORTS_NOT_HASHED: Readonly<Record<string, string
'persistence/memory-mutations.ts': 'verbs.ts request-time verb handlers',
'persistence/verb-errors.ts': 'verbs.ts request-time verb handlers',
'search/transcript-quote.ts': 'verbs.ts request-time verb handlers (remember unquotes a copied fact, #8377)',
+ 'access/member-facts.ts': 'verbs.ts request-time verb handlers (remember refuses a member world write without share, GST-2243)',
'feedback/record.ts': 'verbs.ts request-time answer recording',
'verbs/entity-card.ts': 'verbs.ts request-time verb handlers',
'verbs/entity-card-identity.ts': 'verbs.ts request-time verb handlers (identity siblings notice)',
diff --git a/src/mcp/server.ts b/src/mcp/server.ts
index ce0adccb10..484cf7ccdc 100644
--- a/src/mcp/server.ts
+++ b/src/mcp/server.ts
@@ -24,7 +24,7 @@ import { STATUS_TOOL_DEF, STATUS_TOOL_NAME, attemptStatusRecovery, statusHeadlin
import { installCapabilitiesResource, mcpAdministrationGuidance } from './capabilities.ts';
import { createSkillResources, type SkillResources } from './skill-resources.ts';
import { readLocalWriter, verifyLocalWriter } from '../core/persistence/identity.ts';
-import { ambientOptsFrom } from '../core/facts/writeback-config.ts';
+import { ambientOptsFrom, type WritebackConfig } from '../core/facts/writeback-config.ts';
import { resolveAgentWriteback } from '../core/facts/writeback-settings.ts';
import { isEngineDegraded, onEngineRecovered } from '../core/degraded-marker.ts';
import { assertStdioSourceBindable } from './source-preflight.ts';
@@ -330,6 +330,18 @@ function stdioSurfaceSession(
*/
const READ_ONLY_SERVE_NOTE = '[gbrain-serve] read-only: no persistence consumer, on-commit sync or sweep runs here; a read-write serve, jobs work or autopilot owns them.\n';
+/**
+ * The ambient writeback section's options for a stdio serve: what the session can call, and whether mcp.stdio_member binds
+ * it to a member, whose writes stay private unless shared (GST-2243), so its rule never says "pass visibility: world".
+ */
+export async function stdioAmbientOpts(engine: BrainEngine, writeback: WritebackConfig, allowedOps: ReadonlySet<string> | undefined) {
+ return ambientOptsFrom(writeback, {
+ remember: allowedOps ? allowedOps.has('remember') : true,
+ extractFacts: allowedOps ? allowedOps.has('extract_facts') : true,
+ member: (await stdioMemberIdentity(engine)).some(p => p.startsWith('member:')),
+ });
+}
+
export async function startMcpServer(engine: BrainEngine, opts: { surface?: McpSurface; surfaceSource?: SurfaceSource; invalidSurfaceEnv?: string; sourceGuard?: boolean; onBootPhase?: (phase: string) => void; access?: McpAccess; advertise?: McpSurface } = {}) {
const config = loadConfig();
const bootPhase = (phase: string) => { try { opts.onBootPhase?.(phase); } catch { /* diagnostic only */ } };
@@ -366,11 +378,7 @@ export async function startMcpServer(engine: BrainEngine, opts: { surface?: McpS
// reconnect belongs to tool calls).
const statusMode = statusModeOf(engine);
const writeback = statusMode ? null : (await resolveAgentWriteback(engine, config)).bundle;
- const writebackOpts = writeback ? ambientOptsFrom(writeback, {
- remember: session.allowedOps ? session.allowedOps.has('remember') : true,
- extractFacts: session.allowedOps ? session.allowedOps.has('extract_facts') : true,
- member: (await stdioMemberIdentity(engine)).some(p => p.startsWith('member:')),
- }) : null;
+ const writebackOpts = writeback ? await stdioAmbientOpts(engine, writeback, session.allowedOps) : null;
server = new Server(
{ name: 'gbrain', version: VERSION, description: MCP_SERVER_DESCRIPTION },
// listChanged: a client that handshakes during DEGRADED mode receives the
diff --git a/test/memory-settings.test.ts b/test/memory-settings.test.ts
index 0cab8afa92..c276bc5786 100644
--- a/test/memory-settings.test.ts
+++ b/test/memory-settings.test.ts
@@ -15,6 +15,7 @@ import { buildMcpInstructions } from '../src/mcp/instructions.ts';
import { buildAmbientWritebackSection } from '../src/core/facts/writeback-instructions.ts';
import { ambientOptsFrom, captureLaneStates, resolveWritebackConfig } from '../src/core/facts/writeback-config.ts';
import { resolveAgentWriteback } from '../src/core/facts/writeback-settings.ts';
+import { stdioAmbientOpts } from '../src/mcp/server.ts';
import type { AuthInfo } from '../src/core/ops/contract.ts';
import { addMember } from '../src/core/access/members.ts';
import type { GBrainConfig } from '../src/core/config.ts';
@@ -254,6 +255,18 @@ describe('memory_conversation_mode', () => {
expect(body.rule_text).not.toContain('Pass visibility:');
});
+ test('GST-2243: the stdio serve\'s ambient writeback section carries the member rule only when mcp.stdio_member binds a live member', async () => {
+ await engine.setConfig('memory.agent_writeback', 'all');
+ const { bundle } = await resolveAgentWriteback(engine, CONFIG);
+ expect((await stdioAmbientOpts(engine, bundle, undefined))?.member).toBeUndefined();
+ await addMember(engine, 'alice-example');
+ await engine.setConfig('mcp.stdio_member', 'alice-example');
+ const opts = await stdioAmbientOpts(engine, bundle, undefined);
+ expect(opts?.member).toBe(true);
+ expect(buildAmbientWritebackSection(opts!)).toContain('share: true');
+ expect(await stdioAmbientOpts(engine, bundle, new Set(['search']))).toBeNull();
+ });
+
test('all returns a conversation rule with the brain\'s private posture, even when the operator set off; nothing is stored', async () => {
await engine.setConfig('memory.auto_writeback', 'off');
await engine.setConfig('facts.default_visibility', 'private');
diff --git a/test/postgres-unit-arms.txt b/test/postgres-unit-arms.txt
index 5204d12ad7..a7b240916b 100644
--- a/test/postgres-unit-arms.txt
+++ b/test/postgres-unit-arms.txt
@@ -472,6 +472,7 @@ test/refresh-retry-hint-gst1582.test.ts
test/refresh-write-barrier.test.ts
test/remediation-manual-only.test.ts
test/remember-batch-entity-7432.test.ts
+test/remember-share-gst2243.test.ts
test/repair-apply-pending-6543.test.ts
test/repair-database-stop-gbra133.test.ts
test/repair-embedding-effects.test.ts