Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

fix: a rename on a schema without slug_aliases skips the rename history too; gauge and SQL-text goldens for the v285 statements; measured arm weights for two access files (GBRA-218)

garrytan4c8897e7a6d7
diff --git a/scripts/postgres-arm-weights.json b/scripts/postgres-arm-weights.json
index 4e77e08e82..3dd65bcd01 100644
--- a/scripts/postgres-arm-weights.json
+++ b/scripts/postgres-arm-weights.json
@@ -5,6 +5,8 @@
"test/access-folder-multiconn.test.ts": 4110,
"test/access-folder-rules.test.ts": 18830,
"test/access-members.test.ts": 3930,
+ "test/access-on-behalf-of.test.ts": 13100,
+ "test/access-page-indexes-online.test.ts": 1940,
"test/access-writes.test.ts": 4950,
"test/activation-unbound-rooted-6449.test.ts": 4525,
"test/alias-source-cascade-5094.test.ts": 10600,
diff --git a/src/core/page-state/rename-alias.ts b/src/core/page-state/rename-alias.ts
index cd15622eef..eb1c66f602 100644
--- a/src/core/page-state/rename-alias.ts
+++ b/src/core/page-state/rename-alias.ts
@@ -36,7 +36,7 @@ export async function recordRenameAlias(
ON CONFLICT DO NOTHING`, [sourceId, oldSlug, newSlug]);
});
} catch (error) {
- if (!isMissingSchemaObject(error, 'table', 'slug_rename_history')) throw error;
+ if (!isMissingSchemaObject(error, 'table', 'slug_rename_history') && !isMissingSchemaObject(error, 'table', 'slug_aliases')) throw error;
}
try {
await tx.transaction(async savepoint => {
diff --git a/test/fixtures/goldens/postgres-engine-gauge/acquires-by-case.json b/test/fixtures/goldens/postgres-engine-gauge/acquires-by-case.json
index 4bb5d6dd29..05244666e0 100644
--- a/test/fixtures/goldens/postgres-engine-gauge/acquires-by-case.json
+++ b/test/fixtures/goldens/postgres-engine-gauge/acquires-by-case.json
@@ -405,7 +405,7 @@
"traversePathsDetailed#out+sourceId+linkType": {},
"updatePageContextualRetrievalState#default": {},
"updateSlug#moved": {
- "raw": 13,
+ "raw": 17,
"tx": 1
},
"updateSlug#noop": {
diff --git a/test/fixtures/goldens/sql-text/_driver.json b/test/fixtures/goldens/sql-text/_driver.json
index b845caefd8..114284d0f3 100644
--- a/test/fixtures/goldens/sql-text/_driver.json
+++ b/test/fixtures/goldens/sql-text/_driver.json
@@ -4288,6 +4288,42 @@
},
"via": "unsafe"
},
+ {
+ "paramCount": 2,
+ "unsafeOptions": {
+ "cancelFence": false,
+ "prepare": true,
+ "simple": false
+ },
+ "via": "unsafe"
+ },
+ {
+ "paramCount": 3,
+ "unsafeOptions": {
+ "cancelFence": false,
+ "prepare": true,
+ "simple": false
+ },
+ "via": "unsafe"
+ },
+ {
+ "paramCount": 3,
+ "unsafeOptions": {
+ "cancelFence": false,
+ "prepare": true,
+ "simple": false
+ },
+ "via": "unsafe"
+ },
+ {
+ "paramCount": 3,
+ "unsafeOptions": {
+ "cancelFence": false,
+ "prepare": true,
+ "simple": false
+ },
+ "via": "unsafe"
+ },
{
"paramCount": 3,
"unsafeOptions": {
diff --git a/test/fixtures/goldens/sql-text/pages.json b/test/fixtures/goldens/sql-text/pages.json
index cbf9f0128e..6161102388 100644
--- a/test/fixtures/goldens/sql-text/pages.json
+++ b/test/fixtures/goldens/sql-text/pages.json
@@ -1615,6 +1615,54 @@
"event": "savepoint",
"lane": "tx>sp"
},
+ {
+ "lane": "tx>sp",
+ "params": [
+ "string",
+ "string"
+ ],
+ "sql": "INSERT INTO slug_rename_history (source_id, old_slug, new_slug) SELECT source_id, alias_slug, canonical_slug FROM slug_aliases WHERE source_id = $1 AND alias_slug = $2 ON CONFLICT DO NOTHING",
+ "textSha256": "1b6d164b2a4ccc0c6791b6a84cd01e5e37f81b7930ebdbe5ffce656efa7d4ebf"
+ },
+ {
+ "lane": "tx>sp",
+ "params": [
+ "string",
+ "string",
+ "string",
+ "string"
+ ],
+ "sql": "DELETE FROM slug_rename_history h WHERE h.source_id = $1 AND h.new_slug = $2 AND EXISTS (SELECT 1 FROM slug_rename_history o WHERE o.source_id = $3 AND o.old_slug = h.old_slug AND o.new_slug = $4)",
+ "textSha256": "5e8931b59a4ff174ae7fc2cd166fe13dea4bb24ffb984a0d0e5b637e66f99603"
+ },
+ {
+ "lane": "tx>sp",
+ "params": [
+ "string",
+ "string",
+ "string"
+ ],
+ "sql": "UPDATE slug_rename_history SET new_slug = $1 WHERE source_id = $2 AND new_slug = $3",
+ "textSha256": "2df96db5bfee494a31111c3865dddb8c15c66a897bc64f256967a59a5ab40ff5"
+ },
+ {
+ "lane": "tx>sp",
+ "params": [
+ "string",
+ "string",
+ "string"
+ ],
+ "sql": "INSERT INTO slug_rename_history (source_id, old_slug, new_slug) VALUES ($1, $2, $3) ON CONFLICT DO NOTHING",
+ "textSha256": "5b86c737c773f60e39372e8e7f63408075629e68d715846f30592a383ac8b81a"
+ },
+ {
+ "event": "savepoint-release",
+ "lane": "tx>sp"
+ },
+ {
+ "event": "savepoint",
+ "lane": "tx>sp"
+ },
{
"lane": "tx>sp",
"params": [