Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

fix: extraction_review reports a failed decision for its slug and continues the batch

garrytan5449d30db694
diff --git a/src/core/ops/extraction.ts b/src/core/ops/extraction.ts
index 3e06b40c55..c51c449cfb 100644
--- a/src/core/ops/extraction.ts
+++ b/src/core/ops/extraction.ts
@@ -262,8 +262,9 @@ const extraction_review: Operation = {
{ argv: ['gbrain', 'extraction-pending', '--include', 'possible_duplicates'], mcp: { tool: 'extraction_pending', arguments: { include: ['possible_duplicates'] } } }) });
}
if (ctx.dryRun) return { dry_run: true, action: `extraction_review:${action}`, slugs, ...(action === 'distinct' ? { of } : {}) };
- const results: Array<{ slug: string; status: string }> = [];
+ const results: Array<{ slug: string; status: string; error?: ReturnType<OperationError['toJSON']> }> = [];
const writeRequests: Array<{ slug: string; request_id: unknown; state: unknown }> = [];
+ const failures: OperationError[] = [];
for (const slug of slugs) {
// First-match read is safe here: every write below keys on the RETURNED
// row's page.source_id, so read and write can never target different
@@ -273,11 +274,21 @@ const extraction_review: Operation = {
results.push({ slug, status: 'not_found' });
continue;
}
- const decided = await reviewDecision(ctx, action, slug, page.source_id, of);
+ // A decision that fails is reported for its slug and the batch goes on: the decisions before it already landed.
+ const decided = await reviewDecision(ctx, action, slug, page.source_id, of).catch((error: unknown) => {
+ if (!(error instanceof OperationError)) throw error;
+ failures.push(error);
+ return null;
+ });
+ if (!decided) {
+ results.push({ slug, status: 'failed', error: failures.at(-1)!.toJSON() });
+ continue;
+ }
results.push({ slug, status: decided.status });
if (decided.response) writeRequests.push({ slug, request_id: decided.response.request_id, state: decided.response.state });
}
- return { status: 'ok', action, results, ...(writeRequests.length ? { write_requests: writeRequests } : {}) };
+ if (failures.length === slugs.length) throw failures[0];
+ return { status: failures.length ? 'partial' : 'ok', action, results, ...(writeRequests.length ? { write_requests: writeRequests } : {}) };
},
cliHints: { name: 'extraction-review', positional: ['action'] },
};
diff --git a/test/extraction-review-door.serial.test.ts b/test/extraction-review-door.serial.test.ts
index cb15bd3a88..67e6bfc8f1 100644
--- a/test/extraction-review-door.serial.test.ts
+++ b/test/extraction-review-door.serial.test.ts
@@ -16,6 +16,8 @@ import { disposePersistenceConsumer } from '../src/core/persistence/service.ts';
import { tryAcquireDbLock } from '../src/core/db-lock.ts';
import { publicationGuardId, withPublicationGuard } from '../src/core/persistence/publication-guard.ts';
import { operationsByName, OperationError } from '../src/core/operations.ts';
+import { withCoordinatedWrite } from '../src/core/persistence/context.ts';
+import { TEST_WRITE_ATTRIBUTION } from './helpers/write-attribution.ts';
import {
distinctScenario, promoteScenario, racedDecisionsScenario, rejectScenario, reviewCtx, reviewDoorFixture, seedStub,
type ReviewDoorFixture, type ReviewStorage,
@@ -103,6 +105,29 @@ describe('publication guard', () => {
});
});
+describe('extraction_review batches', () => {
+ test('a decision that fails mid-batch is reported for its slug and the rest of the batch still lands', async () => {
+ fx = await reviewDoorFixture(engine, 'database');
+ const [first, broken, last] = ['people/batch-first-example', 'people/batch-broken-example', 'people/batch-last-example'];
+ for (const slug of [first, broken, last]) await seedStub(engine, slug, 'Batch Example');
+ const malformed = 'Batch Example came up in a call.\n\n<!--- gbrain:facts:begin -->\n| # | claim | kind | confidence | visibility | notability | valid_from | valid_until | source | context |\n'
+ + '|---|---|---|---|---|---|---|---|---|---|\n| 1 | Batchrowzq4 likes tea | fact | 1.0 | world | medium | 2026-01-02 |\n<!--- gbrain:facts:end -->\n';
+ await engine.transaction(tx => withCoordinatedWrite(tx, ['default'], () => tx.executeRaw(
+ 'UPDATE pages SET compiled_truth=$2 WHERE source_id=\'default\' AND slug=$1', [broken, malformed]), TEST_WRITE_ATTRIBUTION));
+ const out = await operationsByName.extraction_review!.handler(reviewCtx(engine), { action: 'promote', slugs: [first, broken, last] })
+ .catch((e: unknown) => e) as { status?: string; results?: Array<Record<string, unknown>>; write_requests?: Array<{ slug: string; state: string }> };
+ expect(out.results?.map(r => [r.slug, r.status])).toEqual([[first, 'promoted'], [broken, 'failed'], [last, 'promoted']]);
+ expect(out.results![1]!.error).toMatchObject({ code: 'invalid_fence', reason: 'target_fence_malformed' });
+ expect(out.status).toBe('partial');
+ expect(out.write_requests?.map(w => [w.slug, w.state])).toEqual([[first, 'committed'], [last, 'committed']]);
+ expect((await engine.getPage(first))!.frontmatter.status).toBe('verified');
+ expect((await engine.getPage(broken))!.frontmatter.status).toBe('unverified');
+ expect((await engine.getPage(last))!.frontmatter.status).toBe('verified');
+ const alone = await operationsByName.extraction_review!.handler(reviewCtx(engine), { action: 'promote', slugs: [broken] }).then(() => null, (e: unknown) => e);
+ expect((alone as OperationError).canonicalCode).toBe('invalid_fence');
+ }, 30_000);
+});
+
describe('extraction_review distinct refusals', () => {
test('a remote caller is told the exact owner command, of included', async () => {
const err = await operationsByName.extraction_review!.handler(reviewCtx(engine, { remote: true }),