Garry's Opinionated OpenClaw/Hermes Agent Brain
TypeScript
Take the wanted-link read time on every extract --stale run and before link preparation resolves
garrytan5d86dc1e93d3
diff --git a/src/commands/extract.ts b/src/commands/extract.tsindex 407184c263..8a00ce9058 100644--- a/src/commands/extract.ts+++ b/src/commands/extract.ts@@ -2198,7 +2198,7 @@ export async function extractStaleFromDB(// #4611: mirrors extractLinksFromDB — configured default, resolved once.const linkDefaultSourceId = await resolveLinkFallbackDefault(engine);// Nothing link-stale: skip the whole-brain resolver reads; the mention pass still runs.- const [readAt, allRefs] = totalStale ? [await wantedReadAt(engine), await engine.listAllPageRefs()] : [undefined, []];+ const [readAt, allRefs] = [await wantedReadAt(engine), totalStale ? await engine.listAllPageRefs() : []];const allSlugs = new Set<string>();const slugToSources = new Map<string, string[]>();for (const ref of allRefs) {diff --git a/src/core/persistence/links-preparation.ts b/src/core/persistence/links-preparation.tsindex bf3006b962..aa167d77ff 100644--- a/src/core/persistence/links-preparation.ts+++ b/src/core/persistence/links-preparation.ts@@ -96,6 +96,7 @@ export const LINK_ENDPOINTS_SQL = `WITH own AS (export async function prepareAutomaticLinks(engine: BrainEngine, slug: string,page: Pick<ParsedPage, 'type' | 'compiled_truth' | 'timeline' | 'frontmatter'> & { id?: number }, sourceId: string, primeSemantics = false) {if (primeSemantics) await primeRelationSemantics(engine);+ const readAt = await wantedReadAt(engine);const resolver = makeResolver(engine, { mode: 'live', sourceId, basenameIndex: () => sourceBasenameIndex(engine, sourceId) });// One settings snapshot for the whole extraction; publication validates it (derived-links.ts). An unreadable// setting leaves the page's links unpublished (stale) rather than extracted under defaults.@@ -119,7 +120,6 @@ export async function prepareAutomaticLinks(engine: BrainEngine, slug: string,roleText ??= await segmentedRoleText(engine, segmented);return extractSegmentedPageLinks(engine, segmented, resolver, { ...o, roleText });};- const readAt = await wantedReadAt(engine);const referenced = new Set([slug]);const initial = await extract({ ...opts, onResolvedFrontmatterTarget: target => referenced.add(target) });// A link written against a renamed page's old slug follows its slug alias, like get_page does.diff --git a/test/wanted-links-stale-count-race.test.ts b/test/wanted-links-stale-count-race.test.tsnew file mode 100644index 0000000000..88325f4699--- /dev/null+++ b/test/wanted-links-stale-count-race.test.ts@@ -0,0 +1,31 @@+/**+ * GST-2460: a page that turns stale after extract --stale's pre-flight count is still extracted.+ * The run used to take the wanted-link read time only when the count was non-zero, so a bare-name+ * row from such a page reached replaceWantedLinks without one and the whole run threw.+ */+import { afterAll, beforeAll, expect, test } from 'bun:test';+import { PGLiteEngine } from '../src/core/pglite-engine.ts';+import { extractStaleFromDB } from '../src/commands/extract.ts';++let engine: PGLiteEngine;+beforeAll(async () => {+ engine = new PGLiteEngine();+ await engine.connect({});+ await engine.initSchema();+}, 60_000);+afterAll(async () => { await engine.disconnect(); }, 60_000);++test('a page that turns stale after the pre-flight count is extracted and stamped', async () => {+ await engine.putPage('notes/call', { type: 'note', title: 'Call', compiled_truth: 'Call about [[Acme Toolkit]].', timeline: '' });+ const count = engine.countStalePagesForExtraction.bind(engine);+ let first = true;+ engine.countStalePagesForExtraction = async opts => {+ if (!first) return count(opts);+ first = false;+ return 0;+ };+ await extractStaleFromDB(engine, { dryRun: false, jsonMode: true, quiet: true, catchUp: true });+ expect(await engine.executeRaw('SELECT target_ref, ref_kind FROM wanted_links')).toEqual([{ target_ref: 'acme-toolkit', ref_kind: 'name' }]);+ const [page] = await engine.executeRaw<{ stamped: boolean }>("SELECT links_extracted_at IS NOT NULL AS stamped FROM pages WHERE slug = 'notes/call'");+ expect(page!.stamped).toBe(true);+}, 120_000);