Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

fix: neutralize tool calls in segmented as_of windows for remote readers

garrytan5ecf310b52a8
diff --git a/src/core/ops/valid-time-read.ts b/src/core/ops/valid-time-read.ts
index 1ada54a5cc..ad505b0ec9 100644
--- a/src/core/ops/valid-time-read.ts
+++ b/src/core/ops/valid-time-read.ts
@@ -280,8 +280,9 @@ async function editionView(ctx: OperationContext, identity: Identity, e: Edition
total = doc.bytes.length; lines = totalLines(doc.bytes);
slice = windowFrom(doc.bytes, offset ?? 0, maxBytes);
}
+ const text = fence(e.segmented && neutralize ? neutralizeToolCalls(slice.text) : slice.text);
const out: Record<string, unknown> = { ...meta, body: 'window', size: { total_bytes: total, ...(lines !== undefined ? { total_lines: lines } : {}) },
- window: quote ? { ...slice, text: fence(slice.text) } : slice, truncated: slice.byte_start > 0 || slice.byte_end < total };
+ window: text === slice.text ? slice : { ...slice, text }, truncated: slice.byte_start > 0 || slice.byte_end < total };
if (slice.byte_end < total) {
const cursor = encodeCursor({ page_id: identity.id, revision: e.versionId === null ? e.revision : `v:${e.versionId}`, view: 'read', offset: slice.byte_end, max_bytes: maxBytes });
out.next_cursor = cursor;
diff --git a/test/valid-time-gbra217.test.ts b/test/valid-time-gbra217.test.ts
index bd011585a5..8fa090e698 100644
--- a/test/valid-time-gbra217.test.ts
+++ b/test/valid-time-gbra217.test.ts
@@ -473,5 +473,23 @@ for (const backend of testBackends()) {
expect(e?.code).toBe('valid_time_undeclared');
expect(JSON.stringify(e?.fix ?? (e as R)?.detail?.fix)).toContain("valid_from: '<DATE>'");
}, 300_000);
+
+ test('a remote as_of window of a segmented conversation summarizes its tool calls, as the plain window does', async () => {
+ const slug = fresh('segmented-conversation');
+ const toolCall = JSON.stringify({ type: 'tool_use', id: 'toolu_probe', name: 'search', input: { query: 'canary-ledger-arguments' } });
+ const turns = Array.from({ length: 12_000 }, (_, i) => `**alice-example** (2026-10-01 9:00 AM): turn ${i} ${'x'.repeat(40)}`);
+ turns.splice(1, 0, `**bob-example** (2026-10-01 9:02 AM): ${toolCall}`);
+ try {
+ await importSegmented(engine, slug, ['---', 'title: Session', 'type: conversation', "valid_from: '2026-01-01'", '---', '', turns.join('\n\n'), ''].join('\n'));
+ } finally { await engine.setConfig('pages.segmented_storage', 'off'); }
+ const plain = await call('get_page', { slug, body: 'window' }, true);
+ expect(plain.window.text).toContain('arguments omitted');
+ expect(JSON.stringify(plain)).not.toContain('canary-ledger-arguments');
+ const dated = await read(slug, '2026-03-01', true);
+ expect(dated.body).toBe('window');
+ expect(dated.window.text).toContain('arguments omitted');
+ expect(JSON.stringify(dated)).not.toContain('canary-ledger-arguments');
+ expect((await read(slug, '2026-03-01')).window.text).toContain('canary-ledger-arguments');
+ }, 300_000);
});
}