Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

Stamp post-delete holds a second later in the purge leftovers test

garrytan64d06dd6b9f3
diff --git a/test/purge-slug-stores-9146.test.ts b/test/purge-slug-stores-9146.test.ts
index fcd10bbf1d..4a5038dcee 100644
--- a/test/purge-slug-stores-9146.test.ts
+++ b/test/purge-slug-stores-9146.test.ts
@@ -53,7 +53,12 @@ const ctx = (engine: BrainEngine): OperationContext => ({ engine, sourceId: 'def
logger: { info() {}, warn() {}, error() {} } } as OperationContext);
const op = (name: string) => operations.find(o => o.name === name)!;
-/** A write-gate hold for the slug created and last seen `ago` before now, labelled `when`, with its receipt. */
+/**
+ * A write-gate hold for the slug created and last seen `ago` before now, labelled `when`, with its receipt. A hold
+ * that arrives after a soft delete is stamped a second later: PGLite's now() has millisecond resolution, so two
+ * back-to-back statements usually share a timestamp, and a hold stamped at the soft delete's instant counts as
+ * arriving at or before it.
+ */
async function hold(engine: BrainEngine, sourceId: string, slug: string, when: string, ago = '0 seconds') {
const [row] = await engine.executeRaw<{ id: string }>(`INSERT INTO write_gate_holds (kind, source_id, slug, fingerprint, detector_version, tier, payload, created_at, last_seen_at)
VALUES ('fact', $1, $2, $3, 1, 'quarantine', $4::text::jsonb, now() - $5::interval, now() - $5::interval) RETURNING id::text AS id`,
@@ -141,7 +146,7 @@ describe('#9146 every hard delete removes the page\'s slug-keyed stores', () =>
await seed(engine, slug);
await engine.softDeletePage(slug, { sourceId: 'default' });
expect(await residue(engine, slug)).toEqual(SEEDED);
- await hold(engine, 'default', slug, 'after');
+ await hold(engine, 'default', slug, 'after', '-1 second');
const purged = await purgeDeletedPagesCoordinated(engine, 0);
expect(purged.slugs).toContain(slug);
expect({ engine: engine.kind, residue: await residue(engine, slug) })
@@ -155,7 +160,7 @@ describe('#9146 every hard delete removes the page\'s slug-keyed stores', () =>
const slug = 'people/erin-example';
await seed(engine, slug);
await engine.softDeletePage(slug, { sourceId: 'default' });
- await engine.executeRaw(`UPDATE write_gate_holds SET status = 'held', last_seen_at = now(), seen_count = seen_count + 1,
+ await engine.executeRaw(`UPDATE write_gate_holds SET status = 'held', last_seen_at = now() + interval '1 second', seen_count = seen_count + 1,
payload = jsonb_set(payload, '{when}', '"reopened"') WHERE source_id = 'default' AND slug = $1`, [slug]);
await engine.executeRaw(`UPDATE write_gate_receipts SET request_id = $1 WHERE target_table = 'write_gate_holds'
AND target_id IN (SELECT id::text FROM write_gate_holds WHERE source_id = 'default' AND slug = $2)`, [`${slug}|reopened`, slug]);