Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

fix(qm): full-suite gaps — v286 CHECK survives a PGLite dump/restore, memory_write in the managed-writer census, memory_recall read-trust class, integer param type in parity; regenerated catalog, migration, export-surface and Postgres doctor goldens

garrytan82fcc2adcbcf
diff --git a/docs/architecture/managed-mutating-writers.tsv b/docs/architecture/managed-mutating-writers.tsv
index e10d0c3641..8f31522fd8 100644
--- a/docs/architecture/managed-mutating-writers.tsv
+++ b/docs/architecture/managed-mutating-writers.tsv
@@ -5,6 +5,7 @@
# early_refusal (refuses on a managed brain before any write), engine_guard (the managed writer trigger refuses its canonical write).
op remember coordinator submitRememberMutation admits a journaled page mutation.
op forget coordinator submitForgetMutation records a coordinated withdrawal.
+op memory_write coordinator Each fact is a remember write (submitRememberMutation) under a per-member child request id.
op put_page coordinator submitPageMutation; unbound Postgres sources refuse unless persistence.unbound_write=database_only.
op put_pages coordinator Every page is admitted as its own coordinated put_page write request, together in one journal transaction (#6007)
op delete_page coordinator submitPageMutation soft delete or trusted-local purge.
diff --git a/src/core/eligibility/registry.ts b/src/core/eligibility/registry.ts
index 413e01bc41..103d162b4d 100644
--- a/src/core/eligibility/registry.ts
+++ b/src/core/eligibility/registry.ts
@@ -25,7 +25,7 @@ export type ReadTrustHandling = 'filtered' | 'labeled' | 'text_free';
export const OP_READ_TRUST: Readonly<Record<string, ReadTrustHandling>> = {
// memory verbs and retrieval
- recall: 'filtered', context_pack: 'filtered', delta: 'filtered',
+ recall: 'filtered', context_pack: 'filtered', delta: 'filtered', memory_recall: 'labeled',
search: 'filtered', search_exact: 'filtered', query: 'filtered', get_page: 'filtered', fetch: 'filtered',
get_chunks: 'filtered', get_timeline: 'filtered', takes_list: 'filtered', takes_search: 'filtered',
assemble_evidence: 'filtered',
diff --git a/src/core/schema-migrations/v286-qm-actor-links.ts b/src/core/schema-migrations/v286-qm-actor-links.ts
index a5dafc8561..447ab4b169 100644
--- a/src/core/schema-migrations/v286-qm-actor-links.ts
+++ b/src/core/schema-migrations/v286-qm-actor-links.ts
@@ -24,7 +24,7 @@ export const v286: Migration = {
sql: `
CREATE TABLE IF NOT EXISTS access_member_links (
system TEXT NOT NULL CHECK (system ~ '^[a-z][a-z0-9_-]{0,31}$'),
- external_id TEXT NOT NULL CHECK (length(external_id) BETWEEN 1 AND 256 AND external_id ~ '^[!-~]+$'),
+ external_id TEXT NOT NULL CHECK (length(external_id) >= 1 AND length(external_id) <= 256 AND external_id ~ '^[!-~]+$'),
member_id TEXT NOT NULL REFERENCES access_members(id) ON DELETE CASCADE,
created_at TIMESTAMPTZ NOT NULL DEFAULT now(),
PRIMARY KEY (system, external_id)
diff --git a/test/fixtures/goldens/catalog/pglite-engine-init-default.json b/test/fixtures/goldens/catalog/pglite-engine-init-default.json
index 430e307df1..f4198bc7d4 100644
--- a/test/fixtures/goldens/catalog/pglite-engine-init-default.json
+++ b/test/fixtures/goldens/catalog/pglite-engine-init-default.json
@@ -6,7 +6,7 @@
"access_group_members.access_group_members_pkey": "p PRIMARY KEY (group_id, member_id)",
"access_groups.access_groups_id_check": "c CHECK ((id ~ '^[a-z0-9][a-z0-9._-]{0,63}$'::text))",
"access_groups.access_groups_pkey": "p PRIMARY KEY (id)",
- "access_member_links.access_member_links_external_id_check": "c CHECK ((((length(external_id) >= 1) AND (length(external_id) <= 256)) AND (external_id ~ '^[!-~]+$'::text)))",
+ "access_member_links.access_member_links_external_id_check": "c CHECK (((length(external_id) >= 1) AND (length(external_id) <= 256) AND (external_id ~ '^[!-~]+$'::text)))",
"access_member_links.access_member_links_member_id_fkey": "f FOREIGN KEY (member_id) REFERENCES access_members(id) ON DELETE CASCADE",
"access_member_links.access_member_links_pkey": "p PRIMARY KEY (system, external_id)",
"access_member_links.access_member_links_system_check": "c CHECK ((system ~ '^[a-z][a-z0-9_-]{0,31}$'::text))",
diff --git a/test/fixtures/goldens/catalog/pglite-engine-init-fts-portuguese.json b/test/fixtures/goldens/catalog/pglite-engine-init-fts-portuguese.json
index 79f7f2a8a9..e4f7385f81 100644
--- a/test/fixtures/goldens/catalog/pglite-engine-init-fts-portuguese.json
+++ b/test/fixtures/goldens/catalog/pglite-engine-init-fts-portuguese.json
@@ -6,7 +6,7 @@
"access_group_members.access_group_members_pkey": "p PRIMARY KEY (group_id, member_id)",
"access_groups.access_groups_id_check": "c CHECK ((id ~ '^[a-z0-9][a-z0-9._-]{0,63}$'::text))",
"access_groups.access_groups_pkey": "p PRIMARY KEY (id)",
- "access_member_links.access_member_links_external_id_check": "c CHECK ((((length(external_id) >= 1) AND (length(external_id) <= 256)) AND (external_id ~ '^[!-~]+$'::text)))",
+ "access_member_links.access_member_links_external_id_check": "c CHECK (((length(external_id) >= 1) AND (length(external_id) <= 256) AND (external_id ~ '^[!-~]+$'::text)))",
"access_member_links.access_member_links_member_id_fkey": "f FOREIGN KEY (member_id) REFERENCES access_members(id) ON DELETE CASCADE",
"access_member_links.access_member_links_pkey": "p PRIMARY KEY (system, external_id)",
"access_member_links.access_member_links_system_check": "c CHECK ((system ~ '^[a-z][a-z0-9_-]{0,31}$'::text))",
diff --git a/test/fixtures/goldens/catalog/pglite-engine-init-high-dims.json b/test/fixtures/goldens/catalog/pglite-engine-init-high-dims.json
index ef592a0386..c5a2315f26 100644
--- a/test/fixtures/goldens/catalog/pglite-engine-init-high-dims.json
+++ b/test/fixtures/goldens/catalog/pglite-engine-init-high-dims.json
@@ -6,7 +6,7 @@
"access_group_members.access_group_members_pkey": "p PRIMARY KEY (group_id, member_id)",
"access_groups.access_groups_id_check": "c CHECK ((id ~ '^[a-z0-9][a-z0-9._-]{0,63}$'::text))",
"access_groups.access_groups_pkey": "p PRIMARY KEY (id)",
- "access_member_links.access_member_links_external_id_check": "c CHECK ((((length(external_id) >= 1) AND (length(external_id) <= 256)) AND (external_id ~ '^[!-~]+$'::text)))",
+ "access_member_links.access_member_links_external_id_check": "c CHECK (((length(external_id) >= 1) AND (length(external_id) <= 256) AND (external_id ~ '^[!-~]+$'::text)))",
"access_member_links.access_member_links_member_id_fkey": "f FOREIGN KEY (member_id) REFERENCES access_members(id) ON DELETE CASCADE",
"access_member_links.access_member_links_pkey": "p PRIMARY KEY (system, external_id)",
"access_member_links.access_member_links_system_check": "c CHECK ((system ~ '^[a-z][a-z0-9_-]{0,31}$'::text))",
diff --git a/test/fixtures/goldens/catalog/postgres-engine-init-default.json b/test/fixtures/goldens/catalog/postgres-engine-init-default.json
index 88711c92c4..34af7dec47 100644
--- a/test/fixtures/goldens/catalog/postgres-engine-init-default.json
+++ b/test/fixtures/goldens/catalog/postgres-engine-init-default.json
@@ -6,7 +6,7 @@
"access_group_members.access_group_members_pkey": "p PRIMARY KEY (group_id, member_id)",
"access_groups.access_groups_id_check": "c CHECK ((id ~ '^[a-z0-9][a-z0-9._-]{0,63}$'::text))",
"access_groups.access_groups_pkey": "p PRIMARY KEY (id)",
- "access_member_links.access_member_links_external_id_check": "c CHECK ((((length(external_id) >= 1) AND (length(external_id) <= 256)) AND (external_id ~ '^[!-~]+$'::text)))",
+ "access_member_links.access_member_links_external_id_check": "c CHECK (((length(external_id) >= 1) AND (length(external_id) <= 256) AND (external_id ~ '^[!-~]+$'::text)))",
"access_member_links.access_member_links_member_id_fkey": "f FOREIGN KEY (member_id) REFERENCES access_members(id) ON DELETE CASCADE",
"access_member_links.access_member_links_pkey": "p PRIMARY KEY (system, external_id)",
"access_member_links.access_member_links_system_check": "c CHECK ((system ~ '^[a-z][a-z0-9_-]{0,31}$'::text))",
diff --git a/test/fixtures/goldens/catalog/postgres-engine-init-fts-portuguese.json b/test/fixtures/goldens/catalog/postgres-engine-init-fts-portuguese.json
index 6346bf56df..e401b9f252 100644
--- a/test/fixtures/goldens/catalog/postgres-engine-init-fts-portuguese.json
+++ b/test/fixtures/goldens/catalog/postgres-engine-init-fts-portuguese.json
@@ -6,7 +6,7 @@
"access_group_members.access_group_members_pkey": "p PRIMARY KEY (group_id, member_id)",
"access_groups.access_groups_id_check": "c CHECK ((id ~ '^[a-z0-9][a-z0-9._-]{0,63}$'::text))",
"access_groups.access_groups_pkey": "p PRIMARY KEY (id)",
- "access_member_links.access_member_links_external_id_check": "c CHECK ((((length(external_id) >= 1) AND (length(external_id) <= 256)) AND (external_id ~ '^[!-~]+$'::text)))",
+ "access_member_links.access_member_links_external_id_check": "c CHECK (((length(external_id) >= 1) AND (length(external_id) <= 256) AND (external_id ~ '^[!-~]+$'::text)))",
"access_member_links.access_member_links_member_id_fkey": "f FOREIGN KEY (member_id) REFERENCES access_members(id) ON DELETE CASCADE",
"access_member_links.access_member_links_pkey": "p PRIMARY KEY (system, external_id)",
"access_member_links.access_member_links_system_check": "c CHECK ((system ~ '^[a-z][a-z0-9_-]{0,31}$'::text))",
diff --git a/test/fixtures/goldens/catalog/postgres-engine-init-high-dims.json b/test/fixtures/goldens/catalog/postgres-engine-init-high-dims.json
index 0faac2bc98..be145948fd 100644
--- a/test/fixtures/goldens/catalog/postgres-engine-init-high-dims.json
+++ b/test/fixtures/goldens/catalog/postgres-engine-init-high-dims.json
@@ -6,7 +6,7 @@
"access_group_members.access_group_members_pkey": "p PRIMARY KEY (group_id, member_id)",
"access_groups.access_groups_id_check": "c CHECK ((id ~ '^[a-z0-9][a-z0-9._-]{0,63}$'::text))",
"access_groups.access_groups_pkey": "p PRIMARY KEY (id)",
- "access_member_links.access_member_links_external_id_check": "c CHECK ((((length(external_id) >= 1) AND (length(external_id) <= 256)) AND (external_id ~ '^[!-~]+$'::text)))",
+ "access_member_links.access_member_links_external_id_check": "c CHECK (((length(external_id) >= 1) AND (length(external_id) <= 256) AND (external_id ~ '^[!-~]+$'::text)))",
"access_member_links.access_member_links_member_id_fkey": "f FOREIGN KEY (member_id) REFERENCES access_members(id) ON DELETE CASCADE",
"access_member_links.access_member_links_pkey": "p PRIMARY KEY (system, external_id)",
"access_member_links.access_member_links_system_check": "c CHECK ((system ~ '^[a-z][a-z0-9_-]{0,31}$'::text))",
diff --git a/test/fixtures/goldens/doctor/json-postgres-fresh.json b/test/fixtures/goldens/doctor/json-postgres-fresh.json
index b2a4f77336..e47cc937ef 100644
--- a/test/fixtures/goldens/doctor/json-postgres-fresh.json
+++ b/test/fixtures/goldens/doctor/json-postgres-fresh.json
@@ -1083,7 +1083,7 @@
{
"category": "ops",
"elapsed_ms": "<volatile>",
- "message": "RLS enabled on 170/170 public tables",
+ "message": "RLS enabled on 171/171 public tables",
"name": "rls",
"status": "ok"
},
@@ -1111,7 +1111,7 @@
{
"category": "meta",
"elapsed_ms": "<volatile>",
- "message": "All 170 table(s) the applied migrations create exist.",
+ "message": "All 171 table(s) the applied migrations create exist.",
"name": "schema_missing_tables",
"status": "ok"
},
diff --git a/test/fixtures/goldens/exports/types.json b/test/fixtures/goldens/exports/types.json
index 71ababed6f..3dc4a95555 100644
--- a/test/fixtures/goldens/exports/types.json
+++ b/test/fixtures/goldens/exports/types.json
@@ -88,7 +88,7 @@
"expireFact: (id: number, opts?: { supersededBy?: number; at?: Date; }) => Promise<boolean>",
"findAnomalies: (opts: AnomaliesOpts) => Promise<AnomalyResult[]>",
"findByTitleFuzzy: (name: string, dirPrefix?: string, minSimilarity?: number, sourceId?: string) => Promise<{ slug: string; similarity: number; } | null>",
- "findCandidateDuplicates: (source_id: string, entitySlug: string, factText: string, opts?: { k?: number; embedding?: Float32Array; embeddingModel?: string | null; arm?: \"keyword\"; attributedTo?: FactAttribution | null; }) => Promise<FactRow[]>",
+ "findCandidateDuplicates: (source_id: string, entitySlug: string, factText: string, opts?: { k?: number; embedding?: Float32Array; embeddingModel?: string | null; arm?: \"keyword\"; attributedTo?: FactAttribution | null; excludeMemberPages?: boolean; }) => Promise<FactRow[]>",
"findDuplicatePage?: ((sourceId: string, opts: { hash: string; frontmatterId?: string | null; excludeSlug?: string; }) => Promise<{ slug: string; id: number; } | null>) | undefined",
"findDuplicatePages?: ((sourceId: string, inputs: ReadonlyArray<{ hash: string; frontmatterId?: string | null; excludeSlug?: string; }>) => Promise<Array<{ slug: string; id: number; } | null>>) | undefined",
"findOntologyConflicts: (opts?: PageReadScope & { minConfidence?: number; visibility?: OntologyReadOpts[\"visibility\"]; }) => Promise<OntologyConflict[]>",
@@ -1098,7 +1098,7 @@
"explainVectorSearch: (embedding: Float32Array, opts?: SearchOpts) => Promise<Record<string, unknown>>",
"findAnomalies: (opts: AnomaliesOpts) => Promise<AnomalyResult[]>",
"findByTitleFuzzy: (name: string, dirPrefix?: string, minSimilarity?: number, sourceId?: string) => Promise<{ slug: string; similarity: number; } | null>",
- "findCandidateDuplicates: (source_id: string, entitySlug: string, factText: string, opts?: { k?: number; embedding?: Float32Array; embeddingModel?: string | null; arm?: \"keyword\"; attributedTo?: FactAttribution | null; }) => Promise<FactRow[]>",
+ "findCandidateDuplicates: (source_id: string, entitySlug: string, factText: string, opts?: { k?: number; embedding?: Float32Array; embeddingModel?: string | null; arm?: \"keyword\"; attributedTo?: FactAttribution | null; excludeMemberPages?: boolean; }) => Promise<FactRow[]>",
"findDuplicatePage: (sourceId: string, opts: { hash: string; frontmatterId?: string | null; excludeSlug?: string; }) => Promise<{ slug: string; id: number; } | null>",
"findDuplicatePages: (sourceId: string, inputs: Parameters<typeof findDuplicatePages>[2]) => Promise<({ slug: string; id: number; } | null)[]>",
"findOntologyConflicts: (opts?: PageReadScope & { minConfidence?: number; visibility?: OntologyReadOpts[\"visibility\"]; }) => Promise<OntologyConflict[]>",
@@ -3643,7 +3643,7 @@
"expireFact: (id: number, opts?: { supersededBy?: number; at?: Date; }) => Promise<boolean>",
"findAnomalies: (opts: AnomaliesOpts) => Promise<AnomalyResult[]>",
"findByTitleFuzzy: (name: string, dirPrefix?: string, minSimilarity?: number, sourceId?: string) => Promise<{ slug: string; similarity: number; } | null>",
- "findCandidateDuplicates: (source_id: string, entitySlug: string, factText: string, opts?: { k?: number; embedding?: Float32Array; embeddingModel?: string | null; arm?: \"keyword\"; attributedTo?: FactAttribution | null; }) => Promise<FactRow[]>",
+ "findCandidateDuplicates: (source_id: string, entitySlug: string, factText: string, opts?: { k?: number; embedding?: Float32Array; embeddingModel?: string | null; arm?: \"keyword\"; attributedTo?: FactAttribution | null; excludeMemberPages?: boolean; }) => Promise<FactRow[]>",
"findDuplicatePage?: ((sourceId: string, opts: { hash: string; frontmatterId?: string | null; excludeSlug?: string; }) => Promise<{ slug: string; id: number; } | null>) | undefined",
"findDuplicatePages?: ((sourceId: string, inputs: ReadonlyArray<{ hash: string; frontmatterId?: string | null; excludeSlug?: string; }>) => Promise<Array<{ slug: string; id: number; } | null>>) | undefined",
"findOntologyConflicts: (opts?: PageReadScope & { minConfidence?: number; visibility?: OntologyReadOpts[\"visibility\"]; }) => Promise<OntologyConflict[]>",
@@ -6956,7 +6956,7 @@
"expireFact: (id: number, opts?: { supersededBy?: number; at?: Date; }) => Promise<boolean>",
"findAnomalies: (opts: AnomaliesOpts) => Promise<AnomalyResult[]>",
"findByTitleFuzzy: (name: string, dirPrefix?: string, minSimilarity?: number, sourceId?: string) => Promise<{ slug: string; similarity: number; } | null>",
- "findCandidateDuplicates: (source_id: string, entitySlug: string, factText: string, opts?: { k?: number; embedding?: Float32Array; embeddingModel?: string | null; arm?: \"keyword\"; attributedTo?: FactAttribution | null; }) => Promise<FactRow[]>",
+ "findCandidateDuplicates: (source_id: string, entitySlug: string, factText: string, opts?: { k?: number; embedding?: Float32Array; embeddingModel?: string | null; arm?: \"keyword\"; attributedTo?: FactAttribution | null; excludeMemberPages?: boolean; }) => Promise<FactRow[]>",
"findDuplicatePage: (sourceId: string, opts: { hash: string; frontmatterId?: string | null; excludeSlug?: string; }) => Promise<{ slug: string; id: number; } | null>",
"findDuplicatePages: (sourceId: string, inputs: Parameters<typeof pagesImpl.findDuplicatePages>[2]) => Promise<({ slug: string; id: number; } | null)[]>",
"findOntologyConflicts: (opts?: PageReadScope & { minConfidence?: number; visibility?: OntologyReadOpts[\"visibility\"]; }) => Promise<OntologyConflict[]>",
diff --git a/test/fixtures/goldens/migrations/records.json b/test/fixtures/goldens/migrations/records.json
index 06ac4a1920..ee9ef3da61 100644
--- a/test/fixtures/goldens/migrations/records.json
+++ b/test/fixtures/goldens/migrations/records.json
@@ -4641,8 +4641,8 @@
"idempotent": true,
"name": "qm_actor_links",
"sql": {
- "length": 1055,
- "sha256": "8ddeb36902321ceb67415726660d47ef7b9b18820202b1f33f0f227c3af4c8b6"
+ "length": 1073,
+ "sha256": "ce07be19659fb418a83d6bffe655e9cf112e523daeb40d3eca69781a4321ad81"
},
"sqlFor": "absent",
"transaction": "absent",
diff --git a/test/fixtures/goldens/pglite-upgrade-replay/catalog-after-boot.json b/test/fixtures/goldens/pglite-upgrade-replay/catalog-after-boot.json
index 2b4af7ff28..fa354be715 100644
--- a/test/fixtures/goldens/pglite-upgrade-replay/catalog-after-boot.json
+++ b/test/fixtures/goldens/pglite-upgrade-replay/catalog-after-boot.json
@@ -6,7 +6,7 @@
"access_group_members.access_group_members_pkey": "p PRIMARY KEY (group_id, member_id)",
"access_groups.access_groups_id_check": "c CHECK ((id ~ '^[a-z0-9][a-z0-9._-]{0,63}$'::text))",
"access_groups.access_groups_pkey": "p PRIMARY KEY (id)",
- "access_member_links.access_member_links_external_id_check": "c CHECK ((((length(external_id) >= 1) AND (length(external_id) <= 256)) AND (external_id ~ '^[!-~]+$'::text)))",
+ "access_member_links.access_member_links_external_id_check": "c CHECK (((length(external_id) >= 1) AND (length(external_id) <= 256) AND (external_id ~ '^[!-~]+$'::text)))",
"access_member_links.access_member_links_member_id_fkey": "f FOREIGN KEY (member_id) REFERENCES access_members(id) ON DELETE CASCADE",
"access_member_links.access_member_links_pkey": "p PRIMARY KEY (system, external_id)",
"access_member_links.access_member_links_system_check": "c CHECK ((system ~ '^[a-z][a-z0-9_-]{0,31}$'::text))",
diff --git a/test/parity.test.ts b/test/parity.test.ts
index 27667c2ff5..33de928934 100644
--- a/test/parity.test.ts
+++ b/test/parity.test.ts
@@ -27,7 +27,7 @@ describe('operations contract parity', () => {
test('every required param has a type', () => {
for (const op of operations) {
for (const [key, def] of Object.entries(op.params)) {
- expect(['string', 'number', 'boolean', 'object', 'array']).toContain(def.type);
+ expect(['string', 'number', 'integer', 'boolean', 'object', 'array']).toContain(def.type);
}
}
});