Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

Pin that a deleted page hides its tags from local callers too and restore brings them back

garrytana12c0f8490a8
diff --git a/test/get-tags-remote-privacy.test.ts b/test/get-tags-remote-privacy.test.ts
index 4229829eb4..7b47a2a717 100644
--- a/test/get-tags-remote-privacy.test.ts
+++ b/test/get-tags-remote-privacy.test.ts
@@ -2,7 +2,9 @@
* Read-path audit #19: get_tags had no private or soft-delete filter, so a
* remote caller learned that a `visibility: private` page exists and read its
* tags. Remote callers now get [] for private and soft-deleted pages; trusted
- * local callers keep the full view.
+ * local callers keep the full view of every live page. A soft-deleted page's
+ * tags are hidden from local callers too, like its facts and timeline, until
+ * restore_page brings the page back.
*/
import { describe, test, expect, beforeAll, afterAll } from 'bun:test';
import { PGLiteEngine } from '../src/core/pglite-engine.ts';
@@ -46,8 +48,17 @@ describe('get_tags respects page visibility for remote callers', () => {
expect(await get_tags.handler(ctxOf(true), { slug: 'notes/gone' })).toEqual([]);
});
- test('trusted local callers keep the full view', async () => {
+ test('trusted local callers keep the full view of live pages', async () => {
expect(await get_tags.handler(ctxOf(false), { slug: 'notes/secret' })).toEqual(['secret-tag']);
- expect(await get_tags.handler(ctxOf(false), { slug: 'notes/gone' })).toEqual(['gone-tag']);
+ });
+
+ test('a soft-deleted page returns no tags to a trusted local caller either, and its tags come back on restore', async () => {
+ expect(await get_tags.handler(ctxOf(false), { slug: 'notes/gone' })).toEqual([]);
+ await engine.executeRaw(`UPDATE pages SET deleted_at = NULL WHERE slug = 'notes/gone'`);
+ try {
+ expect(await get_tags.handler(ctxOf(false), { slug: 'notes/gone' })).toEqual(['gone-tag']);
+ } finally {
+ await engine.executeRaw(`UPDATE pages SET deleted_at = now() WHERE slug = 'notes/gone'`);
+ }
});
});