Skip to content

Garry's Opinionated OpenClaw/Hermes Agent Brain

TypeScript

ship-policy: review_exclude_paths for docs and generated goldens (GBRA-108 ruling)

garrytanb785e7900a90
diff --git a/.gstack/ship-policy.json b/.gstack/ship-policy.json
index 3b4c82c447..c1ce10a2f7 100644
--- a/.gstack/ship-policy.json
+++ b/.gstack/ship-policy.json
@@ -19,5 +19,6 @@
"<!-- gbrain-runbook-stamp: {version} -->"
],
"stamp_placeholders": ["TBD"],
+ "review_exclude_paths": ["docs/**", "test/fixtures/goldens/**"],
"migrations": { "dir": "src/core/schema-migrations", "id": "^v(\\d+)-" }
}
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0bd541f76f..1c7700f4d3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,7 +18,7 @@ identifiers and attribution are available in the pre-removal Git revision
- `src/core/skillopt/loop-deprecation.ts` (new): the notice text, the removal date and the one emitter, called by `gbrain skillopt` (after it resolves the mode, so a resumed loop run counts), the `run_skillopt` op (`ctx.emitNotice`, so MCP and `gbrain call` render it) and the `skillopt` job handler. `skillopt_loop_deprecated` is a new coaching code in `NOTICE_CODES`.
- `gbrain skillopt --help`, the `run_skillopt` description and its `optimizer_mode` parameter, docs/guides/skillopt.md, the tutorial and the `skill-optimizer` skill mark the loop deprecated.
-- Ship policy: `.gstack/ship-policy.json` declares `stamp_placeholders: ["TBD"]` (and `min_gstack_version` 1.94.16.0, the first gstack that reads it), so a branch's own `since: 'TBD'` BEHAVIOR_CHANGES row that the slot restamp fills reads as a stamp instead of a change after /ship's review.
+- Ship policy: `.gstack/ship-policy.json` declares `stamp_placeholders: ["TBD"]` (and `min_gstack_version` 1.94.16.0, the first gstack that reads it), so a branch's own `since: 'TBD'` BEHAVIOR_CHANGES row that the slot restamp fills reads as a stamp instead of a change after /ship's review. It also declares `review_exclude_paths: ["docs/**", "test/fixtures/goldens/**"]`, so once this is on master /ship's reviewers leave docs and generated goldens out of their diffs and a large wave stays under their 2 MB ceiling; the privacy, gitleaks and doc checks still cover those files, and every code, test and config line is still reviewed.
- `test/skillopt/loop-deprecation.serial.test.ts`: each entry point that runs the loop emits the notice exactly once and still runs it; the one-shot default, a one-shot job and the cycle phase emit none.
## [0.60.568.0] - 2026-11-03
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index cef9a3db1b..89e586540d 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -741,6 +741,11 @@ gstack reads both from master, so a branch's edits take effect after it merges.
`stamp_placeholders: ["TBD"]` lets a branch's own `since: 'TBD'` row become
`since: '<version>'` at the slot and still count as a stamp, so /ship's
finish step does not read the restamp as a change made after review.
+ `review_exclude_paths: ["docs/**", "test/fixtures/goldens/**"]` (gstack
+ 1.93.33.0 or newer, read from master only) keeps docs and generated goldens
+ out of /ship's reviewer diffs, so a large wave stays under the reviewers'
+ 2 MB ceiling. Those files stay covered by the privacy, gitleaks and doc
+ checks, and every code, test and config line is still reviewed.
### How a contributor PR lands