Garry's Opinionated OpenClaw/Hermes Agent Brain
TypeScript
fix(meetings): classify Fireflies not_in_team as access denied
garrytanb90a351c5103
diff --git a/src/core/meetings/providers/fireflies.ts b/src/core/meetings/providers/fireflies.tsindex 5375ec0da2..90367e9959 100644--- a/src/core/meetings/providers/fireflies.ts+++ b/src/core/meetings/providers/fireflies.ts@@ -44,7 +44,7 @@ export function classifyFirefliesBody(body: unknown, now: number): void {const code = lower(first.extensions?.code ?? first.code);const message = lower(first.message);const text = typeof first.message === 'string' ? first.message.slice(0, 200) : 'unknown error';- if (/forbidden|permission|not_authorized|privilege/.test(code)) throw new ConnectorAccessDeniedError(`fireflies: ${text}`);+ if (/forbidden|permission|not_authorized|not_in_team|privilege/.test(code)) throw new ConnectorAccessDeniedError(`fireflies: ${text}`);if (/auth|unauthenticated|invalid_api_key|api key/.test(code) || /invalid api key|unauthori[sz]ed|authentication/.test(message)) {throw new ConnectorAuthError(`fireflies: the API key was rejected (${code || 'auth'})`);}diff --git a/test/meetings-unit.test.ts b/test/meetings-unit.test.tsindex d4e3716b4e..ac5437d276 100644--- a/test/meetings-unit.test.ts+++ b/test/meetings-unit.test.ts@@ -32,6 +32,7 @@ describe('Fireflies responses', () => {expect(() => classifyFirefliesBody(err('auth_failed', 'Invalid API key'), NOW)).toThrow(ConnectorAuthError);expect(() => classifyFirefliesBody(err('forbidden'), NOW)).toThrow(ConnectorAccessDeniedError);expect(() => classifyFirefliesBody(err('not_authorized', 'Not authorized to read this team'), NOW)).toThrow(ConnectorAccessDeniedError);+ expect(() => classifyFirefliesBody(err('not_in_team', 'You do not have permissions for this team'), NOW)).toThrow(ConnectorAccessDeniedError);expect(() => classifyFirefliesBody(err('bad_request'), NOW)).toThrow(MeetingProviderError);expect(() => classifyFirefliesBody(err('object_not_found'), NOW)).not.toThrow();expect(() => classifyFirefliesBody({ data: {} }, NOW)).not.toThrow();