Skip to content

A personal assistant that lives on your desktop, remembers what matters, and can use your Mac for you.

TypeScript

docs(odd): record the T23e verification and fixes (L120)

Alan Buscaglia3cc71f8f4338
diff --git a/odd/tasks/gentle-dot.md b/odd/tasks/gentle-dot.md
index e31c313..d638096 100644
--- a/odd/tasks/gentle-dot.md
+++ b/odd/tasks/gentle-dot.md
@@ -197,7 +197,7 @@ Branch: `feat/gentle-dot` · Delivery strategy: `single-pr` (user choice, L7; fo
| T23b | S25.5 (app side), S25.3 (dialogs) | delegated writer (Rust), parallel with T23a | done (B1 fixed in `8ac11aa`, rechecked PASS) | `1c345b5`; RED 22 failing → GREEN; 2 mutation checks; cargo test 348 | Keychain store and native approval dialog in the app |
| T23c | S25.1–S25.3 | delegated writer (Rust + TS), parallel with the T23a/b verifier | done (verified; B2 fixed `4d1eafb`; real Mac pending) | `8ac11aa`; RED across protocol, daemon, Rust, UI → GREEN; 4 mutation checks; pnpm test 658, cargo test 366 | Private app channel (socketpair on fd 3); privileged actions and native approvals only through it |
| T23d | S25.5 (daemon side) | delegated writer (Rust + TS; context backstop) | done (verified, no blockers; A1 fixed, L117) | `8b29bab`, e2e `c6d7c6f`; RED → GREEN; pnpm test 669 (8 clean full runs), cargo test 369, e2e 17 | OAuth in the daemon with the app-backed store; migration from files |
-| T23e | S25.6 | delegated writer (TS; context backstop) | done (verify running) | `9925c39`; RED 17 failing → GREEN; mutation check; pnpm test 688 ×2, e2e 17 | connectors.json HMAC |
+| T23e | S25.6 | delegated writer (TS; context backstop) | done (verified; A1/A3 fixed, L120) | `9925c39`; RED 17 failing → GREEN; mutation check; pnpm test 688 ×2, e2e 17 | connectors.json HMAC |
| T23f | S25.4 (subagents) | after T23c | pending | — | Enable subagents again behind the proxy; real-engine probe |
| T23g | S25.7 | after T23d | pending | — | Linux: Secret Service store and documented limit |
| T23h | S25.8 | after T23c | pending | — | VPS: engine as another OS user, encrypted secrets, PIN approvals |
@@ -313,6 +313,7 @@ Environment notes: Node v24.14.1 and pnpm are present. `cargo` is on PATH but `r
- **L102 (2026-10-09, user):** "bien pero, mientras estoy hablando no me aparece lo que se va enviar como cuando uso el bui† in de mac" — Parakeet transcribes correctly with our capture, so the earlier garbage came from Apple Speech with our converted 16 kHz audio (open: feed Apple the device's native buffers). Live text with the local model (`e027b19`): the recording so far (last 30 s at most) is decoded again every 0.8 s of new audio, skipping when the model is still loading or a decode runs (never blocking the audio thread), serialized with the final decode, and never shown after stop/cancel; RED (compile) → GREEN, cargo test 296. The Voice chip now names the engine ("Offline", "macOS", "Off"; `1396457`). Rebuilt, signed, restarted (also applies the model-chip fix `7ab0c0a`).
- **L103 (2026-10-09, user):** "estaria bueno que si pongo el boton de grabar de nuevo en vez de enviarlo, que se quede escrito en el input para confirmarlo, como se comporta ahora estaria bueno que sea una opcion que uno elijiese". S30.4 updated: review in the input is the default; "Send when I stop" (switch in the recording strip, stored in localStorage) keeps send-on-stop; the mic button reads "Stop and review" or "Stop and send". `e0010eb`: RED 3 failing → GREEN, pnpm test 593 (the earlier tests now cover the option). Rebuilt, signed, restarted.
- **L104 (2026-10-09, user):** "sube todo esto al repo y fijate el readme de gentle ai como es para copiar el estilo y hacer el propio para Gentle Dot"; choices "Gentleman-Programming/gentle-dot, público" and "main + feat/gentle-dot, y abro el PR (recomendado)"; then "usa la rosa con glow como banner". TruffleHog over the whole history: no verified secrets (unverified hits are masking-test fixtures). README rewritten in Gentle-AI's layout with an honest Security status; banner and divider rendered from the Dot's own rose strokes and glow (`docs/brand/tools/build-banner.mjs`); MIT LICENSE as in Gentle-AI. Created the public repo github.com/Gentleman-Programming/gentle-dot, `main` at the first commit `5ec596c`, pushed `feat/gentle-dot` (153 commits, 286 files, +57,416), and opened PR #1 (single-pr). Merge is the user's decision.
+- **L120 (2026-10-10):** Independent verifier on 02784d6..9925c39: pnpm test 688 ×2, e2e 17, typecheck, lint, 23 own probes; the MAC reproduced by an independent Python implementation; 12 kinds of tampering set aside once with content preserved; ordering, A2 closure, regression PASS; no blockers. Fixed inline (RED reproduced both → GREEN, pnpm test 690 ×2): A1 with the app present but the integrity key unreadable or unstorable, the file was loaded unverified and secrets stayed reachable; now the check fails closed (`INTEGRITY_UNCHECKED`: file kept as is, no secret read, every window told) until a start that can check it; A3 a signed file deleted while closed started empty in silence; now `MISSING_NOTICE`. Documented: the HMAC has no counter, so putting back an older signed version is accepted (A2; sending still needs native approval), and deleting the key plus removing `mac` reads as a first start. Kept: A4 a legacy `mcp-auth.json` planted while a migration is retrying is still imported.
- **L119 (2026-10-10):** T23e done (`9925c39`) after the writer stalled 4 minutes on a shell command and was resumed in its own session with timeouts on every command. `connector-integrity.ts`: HMAC-SHA256 over `gentle-dot/connectors.json/v1\n` plus the canonical record without `mac` (sorted keys, no spaces), key = 32 random bytes in the store as `integrity/connectors`; verification after `listen` and before migration, enforce/watch, and the engine start, with app commands waiting for it; a signed file is kept byte for byte when no key is available so it is never rewritten unsigned. A2 closed: an unreadable legacy sign-in file is reported and kept, and the migration retries. Documented limit: a same-user process that deletes the Keychain key and removes `mac` makes the next start treat the file as a first start. Independent verifier launched.
- **L118 (2026-10-09, user):** "si" to merging PR #12 and continuing with T23e. PR #12 merged (`3954682`). T23e design: an HMAC-SHA256 key kept in the Keychain through the app channel (`secret_get/put`, id `integrity/connectors`); the daemon signs `connectors.json` on every write (a `mac` field over a canonical serialization of the rest); at start with the channel, a missing or wrong `mac` on a file that was signed before means it changed while Gentle Dot was closed: the file is moved aside (`connectors.rejected-<timestamp>.json`, private), the daemon starts with no connectors, and the user is told once; the first start after T23e signs the current file (migration); without the channel the file cannot be verified and is loaded as today (connectors needing secrets are already locked there).
- **L117 (2026-10-09):** Independent verifier on eec6776..c6d7c6f: pnpm test 669 ×3 (no flake), e2e 17, cargo test 369, clippy, typecheck, lint; no secret on disk, in WebSocket messages, logs, or errors after connect, refresh, mode change, restart, disconnect, and remove; `secret_*` unreachable from the WebSocket; every proxy method fails closed without the app; OAuth PKCE, wrong state, replayed code, pasted address for another flow, cancel, loopback-only callback, single refresh on 401, no loop without a refresh token; migration survives a kill between put and file rewrite; no blockers. Advisory A1 (serious, would have waited for T23e): a `{secretRef}` planted in `connectors.json` while the daemon was down, in another connector's slot, made the daemon fetch that item and hand it to an agent-chosen stdio command (reproduced with Notion's sign-in). Fixed inline: a reference is honored only in its own slot (ids follow from the connector and field: `connector/<id>/{value|env|header}/<k>`, `connector/<id>/signin`), so `refsOf`, `open`, `isSignedIn`, and `signInState` ignore any other; `signInState` also stopped a planted sign-in reference from sending Notion's cached token to another server. RED (both attacks reproduced on the unfixed code) → GREEN, pnpm test 671 ×2. Other advisories kept: A2 an unparsable legacy `mcp-auth.json` is marked migrated and its secrets stay on disk, and a 0-byte one is deleted; A3 the browser e2e for connector flows were replaced (they failed at the baseline since T23c); A4 an imported server's `callbackUrl` decides the callback host (non-loopback would listen outside; same as baseline); A5 `isSignedIn` is true for an uncached reference, so without the app the list says connected while the proxy fails closed; A6 `serve_secret` copies the secret into a `serde_json::Value` not zeroed; A7 every imported env and header value goes to the Keychain, non-secret ones included.