Skip to content

A personal assistant that lives on your desktop, remembers what matters, and can use your Mac for you.

TypeScript

docs(odd): record the T23d verification and the A1 fix (L117)

Alan Buscaglia57b4e5cccc97
diff --git a/odd/tasks/gentle-dot.md b/odd/tasks/gentle-dot.md
index 8e12830..b0533b4 100644
--- a/odd/tasks/gentle-dot.md
+++ b/odd/tasks/gentle-dot.md
@@ -196,7 +196,7 @@ Branch: `feat/gentle-dot` · Delivery strategy: `single-pr` (user choice, L7; fo
| T23a | S25.4 | delegated writer (daemon proxy), parallel with T23b | done (verified, no blockers) | `6016b43`; RED 14+8 failing → GREEN; mutation check; pnpm test 636 | MCP proxy in the daemon: list/call filtering, hidden-tool refusal, resources, upstream HTTP and stdio |
| T23b | S25.5 (app side), S25.3 (dialogs) | delegated writer (Rust), parallel with T23a | done (B1 fixed in `8ac11aa`, rechecked PASS) | `1c345b5`; RED 22 failing → GREEN; 2 mutation checks; cargo test 348 | Keychain store and native approval dialog in the app |
| T23c | S25.1–S25.3 | delegated writer (Rust + TS), parallel with the T23a/b verifier | done (verified; B2 fixed `4d1eafb`; real Mac pending) | `8ac11aa`; RED across protocol, daemon, Rust, UI → GREEN; 4 mutation checks; pnpm test 658, cargo test 366 | Private app channel (socketpair on fd 3); privileged actions and native approvals only through it |
-| T23d | S25.5 (daemon side) | delegated writer (Rust + TS; context backstop) | done (verify running) | `8b29bab`, e2e `c6d7c6f`; RED → GREEN; pnpm test 669 (8 clean full runs), cargo test 369, e2e 17 | OAuth in the daemon with the app-backed store; migration from files |
+| T23d | S25.5 (daemon side) | delegated writer (Rust + TS; context backstop) | done (verified, no blockers; A1 fixed, L117) | `8b29bab`, e2e `c6d7c6f`; RED → GREEN; pnpm test 669 (8 clean full runs), cargo test 369, e2e 17 | OAuth in the daemon with the app-backed store; migration from files |
| T23e | S25.6 | after T23d | pending | — | connectors.json HMAC |
| T23f | S25.4 (subagents) | after T23c | pending | — | Enable subagents again behind the proxy; real-engine probe |
| T23g | S25.7 | after T23d | pending | — | Linux: Secret Service store and documented limit |
@@ -313,6 +313,7 @@ Environment notes: Node v24.14.1 and pnpm are present. `cargo` is on PATH but `r
- **L102 (2026-10-09, user):** "bien pero, mientras estoy hablando no me aparece lo que se va enviar como cuando uso el bui† in de mac" — Parakeet transcribes correctly with our capture, so the earlier garbage came from Apple Speech with our converted 16 kHz audio (open: feed Apple the device's native buffers). Live text with the local model (`e027b19`): the recording so far (last 30 s at most) is decoded again every 0.8 s of new audio, skipping when the model is still loading or a decode runs (never blocking the audio thread), serialized with the final decode, and never shown after stop/cancel; RED (compile) → GREEN, cargo test 296. The Voice chip now names the engine ("Offline", "macOS", "Off"; `1396457`). Rebuilt, signed, restarted (also applies the model-chip fix `7ab0c0a`).
- **L103 (2026-10-09, user):** "estaria bueno que si pongo el boton de grabar de nuevo en vez de enviarlo, que se quede escrito en el input para confirmarlo, como se comporta ahora estaria bueno que sea una opcion que uno elijiese". S30.4 updated: review in the input is the default; "Send when I stop" (switch in the recording strip, stored in localStorage) keeps send-on-stop; the mic button reads "Stop and review" or "Stop and send". `e0010eb`: RED 3 failing → GREEN, pnpm test 593 (the earlier tests now cover the option). Rebuilt, signed, restarted.
- **L104 (2026-10-09, user):** "sube todo esto al repo y fijate el readme de gentle ai como es para copiar el estilo y hacer el propio para Gentle Dot"; choices "Gentleman-Programming/gentle-dot, público" and "main + feat/gentle-dot, y abro el PR (recomendado)"; then "usa la rosa con glow como banner". TruffleHog over the whole history: no verified secrets (unverified hits are masking-test fixtures). README rewritten in Gentle-AI's layout with an honest Security status; banner and divider rendered from the Dot's own rose strokes and glow (`docs/brand/tools/build-banner.mjs`); MIT LICENSE as in Gentle-AI. Created the public repo github.com/Gentleman-Programming/gentle-dot, `main` at the first commit `5ec596c`, pushed `feat/gentle-dot` (153 commits, 286 files, +57,416), and opened PR #1 (single-pr). Merge is the user's decision.
+- **L117 (2026-10-09):** Independent verifier on eec6776..c6d7c6f: pnpm test 669 ×3 (no flake), e2e 17, cargo test 369, clippy, typecheck, lint; no secret on disk, in WebSocket messages, logs, or errors after connect, refresh, mode change, restart, disconnect, and remove; `secret_*` unreachable from the WebSocket; every proxy method fails closed without the app; OAuth PKCE, wrong state, replayed code, pasted address for another flow, cancel, loopback-only callback, single refresh on 401, no loop without a refresh token; migration survives a kill between put and file rewrite; no blockers. Advisory A1 (serious, would have waited for T23e): a `{secretRef}` planted in `connectors.json` while the daemon was down, in another connector's slot, made the daemon fetch that item and hand it to an agent-chosen stdio command (reproduced with Notion's sign-in). Fixed inline: a reference is honored only in its own slot (ids follow from the connector and field: `connector/<id>/{value|env|header}/<k>`, `connector/<id>/signin`), so `refsOf`, `open`, `isSignedIn`, and `signInState` ignore any other; `signInState` also stopped a planted sign-in reference from sending Notion's cached token to another server. RED (both attacks reproduced on the unfixed code) → GREEN, pnpm test 671 ×2. Other advisories kept: A2 an unparsable legacy `mcp-auth.json` is marked migrated and its secrets stay on disk, and a 0-byte one is deleted; A3 the browser e2e for connector flows were replaced (they failed at the baseline since T23c); A4 an imported server's `callbackUrl` decides the callback host (non-loopback would listen outside; same as baseline); A5 `isSignedIn` is true for an uncached reference, so without the app the list says connected while the proxy fails closed; A6 `serve_secret` copies the secret into a `serde_json::Value` not zeroed; A7 every imported env and header value goes to the Keychain, non-secret ones included.
- **L116 (2026-10-09):** T23d done (`8b29bab`): `secret-source.ts` (`AppSecretSource` over the channel, in-memory cache cleared when the channel closes), `connector-oauth.ts` (daemon-run pi-mcp OAuth with PKCE and a loopback callback, replacing `mcp login`), `connectors.json` holds `{secretRef}` only, one-time migration with a `version: 2` marker (N1 planted files reported and ignored, N2 empty or unreadable files do not block), app-side `secret_*` handlers with id validation and no echo. Limits: security-framework 3.7 cannot read an item's access list, so the daemon only reads ids it recorded; secrets inside a server's URL or args stay in `connectors.json`. Parent fixes: two tests raced engine restarts under load (the proxy key rotates on each restart; and the models list pushed at engine start since L101 could be taken for the reply) — both now wait for the right event (8 consecutive full runs green); `e2e/serve.ts` dropped the removed `GENTLE_DOT_MCP_CLI`; two e2e tests still drove connector changes in the browser, which T23c made app-only, so they now check the browser shows the list with every change disabled and the reason (`c6d7c6f`, e2e 17/17). Independent verifier launched.
- **L115 (2026-10-09, user):** "si" to merging PR #5 and continuing with T23d. PR #5 merged (`ed14f2d`). T23d design: the daemon gets connector secrets from the app over the private channel (`secret_get/put/delete/list`), the app serves them from Keychain items it creates, and the daemon keeps them in memory only; OAuth sign-in and refresh run in the daemon with pi-mcp's OAuth and a channel-backed state store, replacing the `mcp login` CLI and the sign-in home files; existing secrets in the sign-in home, `connectors.json`, and the legacy `mcp-auth.json` migrate once into the Keychain and are removed from the files; without an app channel (attached daemon, `pnpm dev`) connectors that need secrets fail closed with a reason (the VPS store comes in T23h). Writer launched.
- **L114 (2026-10-09):** Independent verifier on 03c5994..8ac11aa: pnpm test 658, cargo test 366, clippy, typecheck, lint; B1 recheck PASS (only the Allow response allows; refuse, abort, stop, cancel, unknown, main-thread call, or failure refuses; the plugin path maps Escape, close, and failure to the refusing label), A2 PASS, channel authentication PASS (10 privileged commands over the WebSocket, including a spoofed clientId, return `app_required` with connectors.json, mcp.json, the proxy's tools/list, and the engine pid unchanged), channel integrity PASS (no listening Unix socket; fd 3 reaches no child: engine, `mcp login`, bash, detached, shell, exec, spawnSync, pi-mcp StdioTransport; frames over 1 MiB close the channel and the WebSocket keeps working), approvals PASS except blocker B2: the import re-read the latest scan after the native answer, so a scan sent while the dialog was open swapped the imported server (reproduced: the dialog showed the filesystem server, `connectors.json` got `/bin/sh -c "echo pwned"`). Fixed inline (`4d1eafb`): `importPlan` freezes a copy of the chosen servers at confirmation and the import uses it; RED reproduced the swap → GREEN, pnpm test 659. Advisories: N1 a legacy `mcp-auth.json` planted after migration adds sign-ins for connectors the daemon lacks (T23d/T23e close it); N2 a 0-byte current `mcp-auth.json` blocks migration; N3 an aborted approval leaves its native dialog open up to 120 s, queuing later ones; N4 anyone launching the daemon with their own socketpair on fd 3 becomes "the app" (by design; T23d/T23e); N5 a malformed `computer_register` over the WebSocket answers `bad_message` instead of `app_required` (still refused). User: "actualiza TODO" (todo list rebuilt). App rebuilt, signed, restarted: the daemon holds fd 3 as a Unix socket connected to the app and the computer helper registered over the channel.