Skip to content

Ghidra is a software reverse engineering (SRE) framework

GP-7057 Revised ElfSymbol.isExternal() method

ghidra11ea863e5ec36
diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/elf/ElfSymbol.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/elf/ElfSymbol.java
index 70540bff28..dab7751e35 100644
--- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/elf/ElfSymbol.java
+++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/elf/ElfSymbol.java
@@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -303,8 +303,7 @@ public class ElfSymbol {
* @return true if this is an external symbol
*/
public boolean isExternal() {
- return (isGlobal() || isWeak()) && getValue() == 0 && getSize() == 0 &&
- getType() == STT_NOTYPE &&
+ return (isGlobal() || isWeak()) &&
getSectionHeaderIndex() == ElfSectionHeaderConstants.SHN_UNDEF;
}