Skip to content

Ghidra is a software reverse engineering (SRE) framework

GP-5361 fix indexoutofboundsexception in decompiler code comparison

James49d848ad5a3a
diff --git a/Ghidra/Features/CodeCompare/src/main/java/ghidra/features/codecompare/graphanalysis/DataGraph.java b/Ghidra/Features/CodeCompare/src/main/java/ghidra/features/codecompare/graphanalysis/DataGraph.java
index f8764305ff..4c350dfe5e 100755
--- a/Ghidra/Features/CodeCompare/src/main/java/ghidra/features/codecompare/graphanalysis/DataGraph.java
+++ b/Ghidra/Features/CodeCompare/src/main/java/ghidra/features/codecompare/graphanalysis/DataGraph.java
@@ -231,13 +231,7 @@ public class DataGraph {
}
}
}
-
- boolean outCast = true;
- if ((out.sinks.size() == 1 && out.vn.isUnique()) || in.sources.size() == 0) {
- outCast = false;
- }
-
- if (outCast) {
+ if (in.sources.size() == 1 && in.sinks.size() == 1 && in.vn.isUnique()) {
// PcodeOp defining CAST input, now defines CAST output
// input is isolated
DataVertex topOp = in.sources.get(0);