Skip to content

Ghidra is a software reverse engineering (SRE) framework

Decode signed zero consistently with other integer values

Rudy Celekli4eba809e5926
diff --git a/Ghidra/Framework/Generic/src/main/java/ghidra/util/NumericUtilities.java b/Ghidra/Framework/Generic/src/main/java/ghidra/util/NumericUtilities.java
index 3050d5933b..0878e9e395 100644
--- a/Ghidra/Framework/Generic/src/main/java/ghidra/util/NumericUtilities.java
+++ b/Ghidra/Framework/Generic/src/main/java/ghidra/util/NumericUtilities.java
@@ -246,7 +246,7 @@ public final class NumericUtilities {
private static BigInteger decodeMagnitude(int p, String s) {
// Special case, so it doesn't get chewed by octal parser
- if ("0".equals(s)) {
+ if (s.length() == p + 1 && s.charAt(p) == '0') {
return BigInteger.ZERO;
}
if (s.regionMatches(true, p, HEX_PREFIX_X, 0, HEX_PREFIX_X.length())) {