Ghidra is a software reverse engineering (SRE) framework
GP-6437 add "string length" column to defined strings table
dev747368c1dddb0cc081
diff --git a/Ghidra/Features/Base/src/main/help/help/topics/DefinedStringsPlugin/DefinedStringsPlugin.htm b/Ghidra/Features/Base/src/main/help/help/topics/DefinedStringsPlugin/DefinedStringsPlugin.htmindex c9c99ab83e..71bc8685d9 100644--- a/Ghidra/Features/Base/src/main/help/help/topics/DefinedStringsPlugin/DefinedStringsPlugin.htm+++ b/Ghidra/Features/Base/src/main/help/help/topics/DefinedStringsPlugin/DefinedStringsPlugin.htm@@ -39,6 +39,7 @@representation into a value of your choice. This is thesame as using the <b>Translate <IMG src="help/shared/arrow.gif" alt="->" border="0">Manual</b> menu item.</li>+ <li>String Length - the number of characters in the string.</li><li>Data Type - mnemonic or data type for the string type.</li><li>Is Ascii - boolean flag that indicates the string has non-ASCII characters.</li><li>Has Encoding Error - boolean flag that indicates the string had byte(s) that could not be converted by the character set.diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/strings/DefinedStringsTableModel.java b/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/strings/DefinedStringsTableModel.javaindex 9627364b07..b65b8b2987 100644--- a/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/strings/DefinedStringsTableModel.java+++ b/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/strings/DefinedStringsTableModel.java@@ -63,7 +63,8 @@ class DefinedStringsTableModel extends AddressBasedTableModel<ProgramLocation> {CHARSET_COL,HAS_ENCODING_ERROR,UNICODE_SCRIPT,- TRANSLATED_VALUE+ TRANSLATED_VALUE,+ LENGTH_COL}DefinedStringsTableModel(PluginTool tool) {@@ -103,6 +104,7 @@ class DefinedStringsTableModel extends AddressBasedTableModel<ProgramLocation> {descriptor.addHiddenColumn(new HasEncodingErrorColumn());descriptor.addHiddenColumn(new UnicodeScriptColumn());descriptor.addHiddenColumn(new TranslatedValueColumn());+ descriptor.addHiddenColumn(new StringLengthColumn());return descriptor;}@@ -220,8 +222,8 @@ class DefinedStringsTableModel extends AddressBasedTableModel<ProgramLocation> {@Overridepublic StringDataInstance getValue(ProgramLocation rowObject, Settings settings,Program program, ServiceProvider serviceProvider) throws IllegalArgumentException {- return StringDataInstance.getStringDataInstance(- DataUtilities.getDataAtLocation(rowObject));+ return StringDataInstance+ .getStringDataInstance(DataUtilities.getDataAtLocation(rowObject));}@Override@@ -269,8 +271,8 @@ class DefinedStringsTableModel extends AddressBasedTableModel<ProgramLocation> {}@Override- public String getValue(ProgramLocation rowObject, Settings settings,- Program program, ServiceProvider serviceProvider) throws IllegalArgumentException {+ public String getValue(ProgramLocation rowObject, Settings settings, Program program,+ ServiceProvider serviceProvider) throws IllegalArgumentException {Data data = DataUtilities.getDataAtLocation(rowObject);if (StringDataInstance.isString(data)) {StringDataInstance sdi = StringDataInstance.getStringDataInstance(data);@@ -358,8 +360,7 @@ class DefinedStringsTableModel extends AddressBasedTableModel<ProgramLocation> {String s = StringDataInstance.getStringDataInstance(data).getStringValue();return (s != null) && s.codePoints()- .anyMatch(- codePoint -> codePoint == StringUtilities.UNICODE_REPLACEMENT);+ .anyMatch(codePoint -> codePoint == StringUtilities.UNICODE_REPLACEMENT);}@Override@@ -450,4 +451,30 @@ class DefinedStringsTableModel extends AddressBasedTableModel<ProgramLocation> {}}++ private static class StringLengthColumn+ extends AbstractProgramLocationTableColumn<ProgramLocation, Integer> {++ @Override+ public String getColumnName() {+ return "String Length";+ }++ @Override+ public Integer getValue(ProgramLocation rowObject, Settings settings, Program program,+ ServiceProvider serviceProvider) throws IllegalArgumentException {++ Data data = DataUtilities.getDataAtLocation(rowObject);+ String s = StringDataInstance.getStringDataInstance(data).getStringValue();++ return s != null ? s.length() : 0;+ }++ @Override+ public ProgramLocation getProgramLocation(ProgramLocation rowObject, Settings settings,+ Program program, ServiceProvider serviceProvider) {+ return rowObject;+ }++ }}