Skip to content

Ghidra is a software reverse engineering (SRE) framework

GP-7422 accept PR with minor comment change

emteerec45ac3000b3b
diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/cmd/function/FunctionPurgeAnalysisCmd.java b/Ghidra/Features/Base/src/main/java/ghidra/app/cmd/function/FunctionPurgeAnalysisCmd.java
index 1cb55d8fad..35d44c880f 100644
--- a/Ghidra/Features/Base/src/main/java/ghidra/app/cmd/function/FunctionPurgeAnalysisCmd.java
+++ b/Ghidra/Features/Base/src/main/java/ghidra/app/cmd/function/FunctionPurgeAnalysisCmd.java
@@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -79,10 +79,8 @@ public class FunctionPurgeAnalysisCmd extends BackgroundCommand<Program> {
break;
}
- // Progress is the number of entry-point addresses consumed so far. Removing the
- // processed range from one copy of the set avoids the full set copy that
- // AddressSet.subtract() made on each iteration, which was quadratic in the
- // number of functions.
+ // Progress is the number of entry-point addresses consumed so far.
+ // Uses set.deleteFromMin() instead of set.subtract() to avoid a full address set copy
set.deleteFromMin(function.getBody().getMaxAddress());
monitor.setProgress(maxCount - set.getNumAddresses());