Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Feature/extend asset profile details dialog by currency and symbol (#1565)
Thomas Kaul07dd22f7fe3e
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 24149c9b6a..923c264a30 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0### Changed- Optimized the page titles in the header for mobile+- Extended the asset profile details dialog in the admin control panel## 1.222.0 - 2022-12-29diff --git a/apps/client/src/app/components/admin-market-data-detail/admin-market-data-detail.component.ts b/apps/client/src/app/components/admin-market-data-detail/admin-market-data-detail.component.tsindex b448e4b5a5..767891a2a1 100644--- a/apps/client/src/app/components/admin-market-data-detail/admin-market-data-detail.component.ts+++ b/apps/client/src/app/components/admin-market-data-detail/admin-market-data-detail.component.ts@@ -20,7 +20,6 @@ import {addDays,format,isBefore,- isDate,isSameDay,isToday,isValid,@@ -31,6 +30,7 @@ import { last } from 'lodash';import { DeviceDetectorService } from 'ngx-device-detector';import { Subject, takeUntil } from 'rxjs';+import { MarketDataDetailDialogParams } from './market-data-detail-dialog/interfaces/interfaces';import { MarketDataDetailDialog } from './market-data-detail-dialog/market-data-detail-dialog.component';@Component({@@ -40,6 +40,7 @@ import { MarketDataDetailDialog } from './market-data-detail-dialog/market-data-templateUrl: './admin-market-data-detail.component.html'})export class AdminMarketDataDetailComponent implements OnChanges, OnInit {+ @Input() currency: string;@Input() dataSource: DataSource;@Input() dateOfFirstActivity: string;@Input() locale = getLocale();@@ -161,9 +162,10 @@ export class AdminMarketDataDetailComponent implements OnChanges, OnInit {}const dialogRef = this.dialog.open(MarketDataDetailDialog, {- data: {+ data: <MarketDataDetailDialogParams>{date,marketPrice,+ currency: this.currency,dataSource: this.dataSource,symbol: this.symbol,user: this.userdiff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/interfaces/interfaces.ts b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/interfaces/interfaces.tsindex 81360878bc..23203a39e5 100644--- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/interfaces/interfaces.ts+++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/interfaces/interfaces.ts@@ -2,6 +2,7 @@ import { User } from '@ghostfolio/common/interfaces';import { DataSource } from '@prisma/client';export interface MarketDataDetailDialogParams {+ currency: string;dataSource: DataSource;date: Date;marketPrice: number;diff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.htmlindex 84dae467b0..230133de78 100644--- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html+++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html@@ -1,5 +1,5 @@<form class="d-flex flex-column h-100">- <h1 mat-dialog-title i18n>Details for {{ data.symbol }}</h1>+ <h1 i18n mat-dialog-title>Details for {{ data.symbol }}</h1><div class="flex-grow-1" mat-dialog-content><div class="mb-3"><mat-form-field appearance="outline" class="w-100">@@ -30,6 +30,7 @@type="number"[(ngModel)]="data.marketPrice"/>+ <span class="ml-2" matSuffix>{{ data.currency }}</span><buttonmat-icon-buttonmatSuffixdiff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.tsindex 9c126862f7..211f33170b 100644--- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts+++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts@@ -14,6 +14,7 @@ import {EnhancedSymbolProfile,UniqueAsset} from '@ghostfolio/common/interfaces';+import { translate } from '@ghostfolio/ui/i18n';import { MarketData } from '@prisma/client';import { Subject } from 'rxjs';import { takeUntil } from 'rxjs/operators';@@ -28,11 +29,13 @@ import { AssetProfileDialogParams } from './interfaces/interfaces';styleUrls: ['./asset-profile-dialog.component.scss']})export class AssetProfileDialog implements OnDestroy, OnInit {+ public assetClass: string;public assetProfile: EnhancedSymbolProfile;public assetProfileForm = this.formBuilder.group({comment: '',symbolMapping: ''});+ public assetSubClass: string;public countries: {[code: string]: { name: string; value: number };};@@ -64,6 +67,9 @@ export class AssetProfileDialog implements OnDestroy, OnInit {.pipe(takeUntil(this.unsubscribeSubject)).subscribe(({ assetProfile, marketData }) => {this.assetProfile = assetProfile;++ this.assetClass = translate(this.assetProfile?.assetClass);+ this.assetSubClass = translate(this.assetProfile?.assetSubClass);this.countries = {};this.marketDataDetails = marketData;this.sectors = {};diff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.htmlindex 7cd4f4d074..c4d6d898e1 100644--- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html+++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html@@ -43,6 +43,7 @@<div class="flex-grow-1" mat-dialog-content><gf-admin-market-data-detailclass="mb-3"+ [currency]="assetProfile?.currency"[dataSource]="data.dataSource"[dateOfFirstActivity]="assetProfile?.dateOfFirstActivity"[locale]="data.locale"@@ -51,6 +52,16 @@(marketDataChanged)="onMarketDataChanged($event)"></gf-admin-market-data-detail><div class="row">+ <div class="col-6 mb-3">+ <gf-value i18n size="medium" [value]="assetProfile?.symbol"+ >Symbol</gf-value+ >+ </div>+ <div class="col-6 mb-3">+ <gf-value i18n size="medium" [value]="assetProfile?.currency"+ >Currency</gf-value+ >+ </div><div class="col-6 mb-3"><gf-valuei18n@@ -71,11 +82,7 @@></div><div class="col-6 mb-3">- <gf-value- i18n- size="medium"- [hidden]="!assetProfile?.assetClass"- [value]="assetProfile?.assetClass"+ <gf-value i18n size="medium" [hidden]="!assetClass" [value]="assetClass">Asset Class</gf-value></div>@@ -83,8 +90,8 @@<gf-valuei18nsize="medium"- [hidden]="!assetProfile?.assetSubClass"- [value]="assetProfile?.assetSubClass"+ [hidden]="!assetSubClass"+ [value]="assetSubClass">Asset Sub Class</gf-value></div>