Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/enforce noImplicitThis and allowUnreachableCode TypeScript rules (#7354)

Kenrick Tandrian0ad326b7c883
diff --git a/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts b/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts
index 8987181067..7eb09d966f 100644
--- a/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts
+++ b/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts
@@ -1,4 +1,4 @@
-import { Job, JobOptions } from 'bull';
+import type { Job, JobId, JobOptions } from 'bull';
import { setTimeout } from 'timers/promises';
import { PortfolioSnapshotQueueJob } from './interfaces/portfolio-snapshot-queue-job.interface';
@@ -10,8 +10,8 @@ export const PortfolioSnapshotServiceMock = {
data: PortfolioSnapshotQueueJob;
name: string;
opts?: JobOptions;
- }): Promise<Job<any>> {
- const mockJob: Partial<Job<any>> = {
+ }): Promise<Job> {
+ const mockJob: Partial<Job> = {
finished: async () => {
await setTimeout(100);
@@ -21,12 +21,12 @@ export const PortfolioSnapshotServiceMock = {
this.jobsStore.set(opts?.jobId, mockJob);
- return Promise.resolve(mockJob as Job<any>);
+ return Promise.resolve(mockJob as Job);
},
- getJob(jobId: string): Promise<Job<any>> {
+ getJob(jobId: JobId): Promise<Job> {
const job = this.jobsStore.get(jobId);
- return Promise.resolve(job as Job<any>);
+ return Promise.resolve(job as Job);
},
- jobsStore: new Map<string, Partial<Job<any>>>()
+ jobsStore: new Map<JobId, Partial<Job>>()
};
diff --git a/tsconfig.base.json b/tsconfig.base.json
index 909e1757ab..1c1cca5cef 100644
--- a/tsconfig.base.json
+++ b/tsconfig.base.json
@@ -29,12 +29,12 @@
"strictPropertyInitialization": false,
"noImplicitReturns": false,
"noImplicitAny": false,
- "noImplicitThis": false,
+ "noImplicitThis": true,
"noImplicitOverride": false,
"noPropertyAccessFromIndexSignature": false,
"noUnusedLocals": true,
"noUnusedParameters": true,
- "allowUnreachableCode": true
+ "allowUnreachableCode": false
},
"exclude": ["node_modules", "tmp"]
}