Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/extend menu in activities table component (#5855)

David Requeno0ea2edd1e550
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8245505b54..d0f90277ed 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+## Unreleased
+
+### Added
+
+- Extended the activities table menu with a _View Holding_ item
+
## 2.212.0 - 2025-10-29
### Added
diff --git a/libs/ui/src/lib/activities-table/activities-table.component.html b/libs/ui/src/lib/activities-table/activities-table.component.html
index 843832e1ae..e230c0bcdd 100644
--- a/libs/ui/src/lib/activities-table/activities-table.component.html
+++ b/libs/ui/src/lib/activities-table/activities-table.component.html
@@ -437,6 +437,14 @@
class="no-max-width"
xPosition="before"
>
+ @if (canClickActivity(element)) {
+ <button mat-menu-item (click)="onClickActivity(element)">
+ <span class="align-items-center d-flex">
+ <ion-icon class="mr-2" name="wallet-outline" />
+ <span i18n>View Holding</span>
+ </span>
+ </button>
+ }
<button mat-menu-item (click)="onUpdateActivity(element)">
<span class="align-items-center d-flex">
<ion-icon class="mr-2" name="create-outline" />
@@ -479,11 +487,7 @@
*matRowDef="let row; columns: displayedColumns"
mat-row
[ngClass]="{
- 'cursor-pointer':
- hasPermissionToOpenDetails &&
- isExcludedFromAnalysis(row) === false &&
- row.isDraft === false &&
- ['BUY', 'DIVIDEND', 'SELL'].includes(row.type)
+ 'cursor-pointer': canClickActivity(row)
}"
(click)="onClickActivity(row)"
></tr>
diff --git a/libs/ui/src/lib/activities-table/activities-table.component.ts b/libs/ui/src/lib/activities-table/activities-table.component.ts
index ce2de1caaa..0b58bda94b 100644
--- a/libs/ui/src/lib/activities-table/activities-table.component.ts
+++ b/libs/ui/src/lib/activities-table/activities-table.component.ts
@@ -56,7 +56,8 @@ import {
documentTextOutline,
ellipsisHorizontal,
ellipsisVertical,
- trashOutline
+ trashOutline,
+ walletOutline
} from 'ionicons/icons';
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
import { Subject, Subscription, takeUntil } from 'rxjs';
@@ -153,7 +154,8 @@ export class GfActivitiesTableComponent
documentTextOutline,
ellipsisHorizontal,
ellipsisVertical,
- trashOutline
+ trashOutline,
+ walletOutline
});
}
@@ -226,6 +228,15 @@ export class GfActivitiesTableComponent
return numSelectedRows === numTotalRows;
}
+ public canClickActivity(activity: Activity) {
+ return (
+ this.hasPermissionToOpenDetails &&
+ this.isExcludedFromAnalysis(activity) === false &&
+ activity.isDraft === false &&
+ ['BUY', 'DIVIDEND', 'SELL'].includes(activity.type)
+ );
+ }
+
public isExcludedFromAnalysis(activity: Activity) {
return (
activity.account?.isExcluded ||
@@ -244,12 +255,7 @@ export class GfActivitiesTableComponent
if (!activity.error) {
this.selectedRows.toggle(activity);
}
- } else if (
- this.hasPermissionToOpenDetails &&
- this.isExcludedFromAnalysis(activity) === false &&
- activity.isDraft === false &&
- ['BUY', 'DIVIDEND', 'SELL'].includes(activity.type)
- ) {
+ } else if (this.canClickActivity(activity)) {
this.activityClicked.emit({
dataSource: activity.SymbolProfile.dataSource,
symbol: activity.SymbolProfile.symbol