Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/fix asset class of cash position for empty account (#2378)

Thomas Kaul0f7c6ff0fe12
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 32d4fd62f4..5e44452949 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Added support for dates in `DD.MM.YYYY` format in the activities import
- Set up the language localization for Türkçe (`tr`)
+### Fixed
+
+- Fixed an issue with the cash position in the holdings table
+
## 2.4.0 - 2023-09-19
### Added
diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts
index ef6f3af998..ff31612804 100644
--- a/apps/api/src/app/portfolio/portfolio.controller.ts
+++ b/apps/api/src/app/portfolio/portfolio.controller.ts
@@ -173,8 +173,14 @@ export class PortfolioController {
for (const [symbol, portfolioPosition] of Object.entries(holdings)) {
holdings[symbol] = {
...portfolioPosition,
- assetClass: hasDetails ? portfolioPosition.assetClass : undefined,
- assetSubClass: hasDetails ? portfolioPosition.assetSubClass : undefined,
+ assetClass:
+ hasDetails || portfolioPosition.assetClass === 'CASH'
+ ? portfolioPosition.assetClass
+ : undefined,
+ assetSubClass:
+ hasDetails || portfolioPosition.assetSubClass === 'CASH'
+ ? portfolioPosition.assetSubClass
+ : undefined,
countries: hasDetails ? portfolioPosition.countries : [],
currency: hasDetails ? portfolioPosition.currency : undefined,
markets: hasDetails ? portfolioPosition.markets : undefined,