Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Bugfix/improve error handling in benchmark calculation (#1246)
Thomas Kaul0fcfa6c1bd3e
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 916edcdb58..c6f5db1c73 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0- Upgraded `yahoo-finance2` from version `2.3.3` to `2.3.6`+### Fixed++- Improved the error handling in the benchmark calculation+## 1.191.0 - 10.09.2022### Changeddiff --git a/apps/api/src/app/benchmark/benchmark.service.ts b/apps/api/src/app/benchmark/benchmark.service.tsindex 7987cb5b92..71337c6ab7 100644--- a/apps/api/src/app/benchmark/benchmark.service.ts+++ b/apps/api/src/app/benchmark/benchmark.service.ts@@ -31,7 +31,11 @@ export class BenchmarkService {) {}public calculateChangeInPercentage(baseValue: number, currentValue: number) {- return new Big(currentValue).div(baseValue).minus(1).toNumber();+ if (baseValue && currentValue) {+ return new Big(currentValue).div(baseValue).minus(1).toNumber();+ }++ return 0;}public async getBenchmarks({ useCache = true } = {}): Promise<