Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/clean up unused interfaces (#4685)

Thomas Kaul11629ffd2664
diff --git a/apps/api/src/models/interfaces/portfolio.interface.ts b/apps/api/src/models/interfaces/portfolio.interface.ts
deleted file mode 100644
index b369202cd4..0000000000
--- a/apps/api/src/models/interfaces/portfolio.interface.ts
+++ /dev/null
@@ -1,23 +0,0 @@
-import { PortfolioItem, Position } from '@ghostfolio/common/interfaces';
-
-import { Order } from '../order';
-
-export interface PortfolioInterface {
- get(aDate?: Date): PortfolioItem[];
-
- getFees(): number;
-
- getPositions(aDate: Date): {
- [symbol: string]: Position;
- };
-
- getSymbols(aDate?: Date): string[];
-
- getTotalBuy(): number;
-
- getTotalSell(): number;
-
- getOrders(): Order[];
-
- getValue(aDate?: Date): number;
-}
diff --git a/libs/common/src/lib/interfaces/index.ts b/libs/common/src/lib/interfaces/index.ts
index bdf982f551..e401705fbe 100644
--- a/libs/common/src/lib/interfaces/index.ts
+++ b/libs/common/src/lib/interfaces/index.ts
@@ -29,8 +29,6 @@ import type { PortfolioChart } from './portfolio-chart.interface';
import type { PortfolioDetails } from './portfolio-details.interface';
import type { PortfolioDividends } from './portfolio-dividends.interface';
import type { PortfolioInvestments } from './portfolio-investments.interface';
-import type { PortfolioItem } from './portfolio-item.interface';
-import type { PortfolioOverview } from './portfolio-overview.interface';
import type { PortfolioPerformance } from './portfolio-performance.interface';
import type { PortfolioPosition } from './portfolio-position.interface';
import type { PortfolioReportRule } from './portfolio-report-rule.interface';
@@ -116,8 +114,6 @@ export {
PortfolioHoldingResponse,
PortfolioHoldingsResponse,
PortfolioInvestments,
- PortfolioItem,
- PortfolioOverview,
PortfolioPerformance,
PortfolioPerformanceResponse,
PortfolioPosition,
diff --git a/libs/common/src/lib/interfaces/portfolio-item.interface.ts b/libs/common/src/lib/interfaces/portfolio-item.interface.ts
deleted file mode 100644
index a3e42a05fa..0000000000
--- a/libs/common/src/lib/interfaces/portfolio-item.interface.ts
+++ /dev/null
@@ -1,9 +0,0 @@
-import { Position } from '@ghostfolio/common/interfaces';
-
-export interface PortfolioItem {
- date: string;
- grossPerformancePercent: number;
- investment: number;
- positions: { [symbol: string]: Position };
- value: number;
-}
diff --git a/libs/common/src/lib/interfaces/portfolio-overview.interface.ts b/libs/common/src/lib/interfaces/portfolio-overview.interface.ts
deleted file mode 100644
index c9c20c28ca..0000000000
--- a/libs/common/src/lib/interfaces/portfolio-overview.interface.ts
+++ /dev/null
@@ -1,8 +0,0 @@
-export interface PortfolioOverview {
- cash: number;
- committedFunds: number;
- fees: number;
- ordersCount: number;
- totalBuy: number;
- totalSell: number;
-}