Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/migrate ESLint configuration to flat config format without FlatCompat (#7938)

David Requeno1a744292741f
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a03fdc09a3..e5036ab1ab 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Improved the get quotes functionality of the _Manual_ service
+- Migrated the _ESLint_ configuration to the flat config format without `FlatCompat`
- Upgraded `chartjs-chart-treemap` from version `4.2.0` to `4.2.2`
### Fixed
diff --git a/apps/client/eslint.config.cjs b/apps/client/eslint.config.cjs
index bcbe2c1c13..b2eb1117ce 100644
--- a/apps/client/eslint.config.cjs
+++ b/apps/client/eslint.config.cjs
@@ -1,6 +1,6 @@
const baseConfig = require('../../eslint.config.cjs');
const angularEslintPlugin = require('@angular-eslint/eslint-plugin');
-const typescriptEslintPlugin = require('@typescript-eslint/eslint-plugin');
+const typescriptEslintPlugin = require('typescript-eslint').plugin;
module.exports = [
{
diff --git a/eslint.config.cjs b/eslint.config.cjs
index 76d627d182..9c1b2024b6 100644
--- a/eslint.config.cjs
+++ b/eslint.config.cjs
@@ -1,12 +1,7 @@
-const { FlatCompat } = require('@eslint/eslintrc');
-const js = require('@eslint/js');
const nxEslintPlugin = require('@nx/eslint-plugin');
+const importPlugin = require('eslint-plugin-import');
const storybook = require('eslint-plugin-storybook');
-
-const compat = new FlatCompat({
- baseDirectory: __dirname,
- recommendedConfig: js.configs.recommended
-});
+const typescriptEslint = require('typescript-eslint');
module.exports = [
{
@@ -35,160 +30,135 @@ module.exports = [
'no-extra-semi': 'off'
}
},
- ...compat
- .config({
- extends: ['plugin:@nx/typescript']
- })
- .map((config) => ({
- ...config,
- files: ['**/*.ts', '**/*.tsx', '**/*.cts', '**/*.mts'],
- rules: {
- ...config.rules
- }
- })),
- ...compat
- .config({
- extends: ['plugin:@nx/javascript']
- })
- .map((config) => ({
- ...config,
- files: ['**/*.js', '**/*.jsx', '**/*.cjs', '**/*.mjs'],
- rules: {
- ...config.rules
- }
- })),
- ...compat
- .config({
- plugins: ['eslint-plugin-import', '@typescript-eslint'],
- extends: [
- 'plugin:@typescript-eslint/recommended-type-checked',
- 'plugin:@typescript-eslint/stylistic-type-checked'
- ]
- })
- .map((config) => ({
- ...config,
- files: ['**/*.ts'],
- rules: {
- ...config.rules,
- '@typescript-eslint/consistent-indexed-object-style': 'off',
- '@typescript-eslint/dot-notation': 'off',
- '@typescript-eslint/explicit-member-accessibility': [
- 'off',
- {
- accessibility: 'explicit'
- }
- ],
- '@typescript-eslint/member-ordering': 'warn',
- '@typescript-eslint/naming-convention': [
- 'off',
- {
- selector: 'default',
- format: ['camelCase'],
- leadingUnderscore: 'allow',
- trailingUnderscore: 'allow'
- },
- {
- selector: ['variable', 'classProperty', 'typeProperty'],
- format: ['camelCase', 'UPPER_CASE'],
- leadingUnderscore: 'allow',
- trailingUnderscore: 'allow'
- },
- {
- selector: 'objectLiteralProperty',
- format: null
- },
- {
- selector: 'enumMember',
- format: ['camelCase', 'UPPER_CASE', 'PascalCase']
- },
- {
- selector: 'typeLike',
- format: ['PascalCase']
- }
- ],
- '@typescript-eslint/no-empty-interface': 'warn',
- '@typescript-eslint/no-inferrable-types': [
- 'warn',
- {
- ignoreParameters: true
- }
- ],
- '@typescript-eslint/no-non-null-assertion': 'warn',
- '@typescript-eslint/no-shadow': [
- 'warn',
- {
- hoist: 'all'
- }
- ],
- '@typescript-eslint/unified-signatures': 'error',
- '@typescript-eslint/no-loss-of-precision': 'warn',
- '@typescript-eslint/no-var-requires': 'warn',
- 'arrow-body-style': 'off',
- 'constructor-super': 'error',
- eqeqeq: ['error', 'smart'],
- 'guard-for-in': 'warn',
- 'id-blacklist': 'off',
- 'id-match': 'off',
- 'import/no-deprecated': 'warn',
- 'no-bitwise': 'error',
- 'no-caller': 'error',
- 'no-debugger': 'error',
- 'no-empty': 'off',
- 'no-eval': 'error',
- 'no-fallthrough': 'error',
- 'no-new-wrappers': 'error',
- 'no-restricted-imports': ['error', 'rxjs/Rx'],
- 'no-undef-init': 'error',
- 'no-underscore-dangle': 'off',
- 'no-var': 'error',
- radix: 'error',
- 'no-unsafe-optional-chaining': 'warn',
- 'no-extra-boolean-cast': 'warn',
- 'no-empty-pattern': 'warn',
- 'no-useless-catch': 'warn',
- 'no-unsafe-finally': 'warn',
- 'no-prototype-builtins': 'warn',
- 'no-async-promise-executor': 'warn',
- 'no-constant-condition': 'warn',
+ ...nxEslintPlugin.configs['flat/typescript'],
+ ...nxEslintPlugin.configs['flat/javascript'],
+ ...typescriptEslint.config({
+ files: ['**/*.ts'],
+ plugins: { import: importPlugin },
+ extends: [
+ typescriptEslint.configs.recommendedTypeChecked,
+ typescriptEslint.configs.stylisticTypeChecked
+ ],
+ rules: {
+ '@typescript-eslint/consistent-indexed-object-style': 'off',
+ '@typescript-eslint/dot-notation': 'off',
+ '@typescript-eslint/explicit-member-accessibility': [
+ 'off',
+ {
+ accessibility: 'explicit'
+ }
+ ],
+ '@typescript-eslint/member-ordering': 'warn',
+ '@typescript-eslint/naming-convention': [
+ 'off',
+ {
+ selector: 'default',
+ format: ['camelCase'],
+ leadingUnderscore: 'allow',
+ trailingUnderscore: 'allow'
+ },
+ {
+ selector: ['variable', 'classProperty', 'typeProperty'],
+ format: ['camelCase', 'UPPER_CASE'],
+ leadingUnderscore: 'allow',
+ trailingUnderscore: 'allow'
+ },
+ {
+ selector: 'objectLiteralProperty',
+ format: null
+ },
+ {
+ selector: 'enumMember',
+ format: ['camelCase', 'UPPER_CASE', 'PascalCase']
+ },
+ {
+ selector: 'typeLike',
+ format: ['PascalCase']
+ }
+ ],
+ '@typescript-eslint/no-empty-interface': 'warn',
+ '@typescript-eslint/no-inferrable-types': [
+ 'warn',
+ {
+ ignoreParameters: true
+ }
+ ],
+ '@typescript-eslint/no-non-null-assertion': 'warn',
+ '@typescript-eslint/no-shadow': [
+ 'warn',
+ {
+ hoist: 'all'
+ }
+ ],
+ '@typescript-eslint/unified-signatures': 'error',
+ '@typescript-eslint/no-loss-of-precision': 'warn',
+ '@typescript-eslint/no-var-requires': 'warn',
+ 'arrow-body-style': 'off',
+ 'constructor-super': 'error',
+ eqeqeq: ['error', 'smart'],
+ 'guard-for-in': 'warn',
+ 'id-blacklist': 'off',
+ 'id-match': 'off',
+ 'import/no-deprecated': 'warn',
+ 'no-bitwise': 'error',
+ 'no-caller': 'error',
+ 'no-debugger': 'error',
+ 'no-empty': 'off',
+ 'no-eval': 'error',
+ 'no-fallthrough': 'error',
+ 'no-new-wrappers': 'error',
+ 'no-restricted-imports': ['error', 'rxjs/Rx'],
+ 'no-undef-init': 'error',
+ 'no-underscore-dangle': 'off',
+ 'no-var': 'error',
+ radix: 'error',
+ 'no-unsafe-optional-chaining': 'warn',
+ 'no-extra-boolean-cast': 'warn',
+ 'no-empty-pattern': 'warn',
+ 'no-useless-catch': 'warn',
+ 'no-unsafe-finally': 'warn',
+ 'no-prototype-builtins': 'warn',
+ 'no-async-promise-executor': 'warn',
+ 'no-constant-condition': 'warn',
- // The following rules are part of eslint:recommended
- // and can be remove once solved
- 'no-loss-of-precision': 'warn',
+ // The following rules are part of eslint:recommended
+ // and can be remove once solved
+ 'no-loss-of-precision': 'warn',
- // The following rules are part of @typescript-eslint/recommended-type-checked
- // and can be remove once solved
- '@typescript-eslint/await-thenable': 'warn',
- '@typescript-eslint/ban-ts-comment': 'warn',
- '@typescript-eslint/no-base-to-string': 'warn',
- '@typescript-eslint/no-empty-object-type': 'warn',
- '@typescript-eslint/no-explicit-any': 'warn',
- '@typescript-eslint/no-floating-promises': 'warn',
- '@typescript-eslint/no-misused-promises': 'warn',
- '@typescript-eslint/no-redundant-type-constituents': 'warn',
- '@typescript-eslint/no-require-imports': 'warn',
- '@typescript-eslint/no-unnecessary-type-assertion': 'warn',
- '@typescript-eslint/no-unsafe-argument': 'warn',
- '@typescript-eslint/no-unsafe-assignment': 'warn',
- '@typescript-eslint/no-unsafe-enum-comparison': 'warn',
- '@typescript-eslint/no-unsafe-member-access': 'warn',
- '@typescript-eslint/no-unsafe-return': 'warn',
- '@typescript-eslint/no-unsafe-call': 'warn',
- '@typescript-eslint/no-unused-vars': [
- 'error',
- {
- caughtErrors: 'none'
- }
- ],
- '@typescript-eslint/no-wrapper-object-types': 'warn',
- '@typescript-eslint/only-throw-error': 'warn',
- '@typescript-eslint/prefer-promise-reject-errors': 'warn',
- '@typescript-eslint/require-await': 'warn',
- '@typescript-eslint/restrict-template-expressions': 'warn',
- '@typescript-eslint/unbound-method': 'warn',
+ // The following rules are part of @typescript-eslint/recommended-type-checked
+ // and can be remove once solved
+ '@typescript-eslint/await-thenable': 'warn',
+ '@typescript-eslint/ban-ts-comment': 'warn',
+ '@typescript-eslint/no-base-to-string': 'warn',
+ '@typescript-eslint/no-empty-object-type': 'warn',
+ '@typescript-eslint/no-explicit-any': 'warn',
+ '@typescript-eslint/no-floating-promises': 'warn',
+ '@typescript-eslint/no-misused-promises': 'warn',
+ '@typescript-eslint/no-redundant-type-constituents': 'warn',
+ '@typescript-eslint/no-require-imports': 'warn',
+ '@typescript-eslint/no-unnecessary-type-assertion': 'warn',
+ '@typescript-eslint/no-unsafe-argument': 'warn',
+ '@typescript-eslint/no-unsafe-assignment': 'warn',
+ '@typescript-eslint/no-unsafe-enum-comparison': 'warn',
+ '@typescript-eslint/no-unsafe-member-access': 'warn',
+ '@typescript-eslint/no-unsafe-return': 'warn',
+ '@typescript-eslint/no-unsafe-call': 'warn',
+ '@typescript-eslint/no-unused-vars': [
+ 'error',
+ {
+ caughtErrors: 'none'
+ }
+ ],
+ '@typescript-eslint/no-wrapper-object-types': 'warn',
+ '@typescript-eslint/only-throw-error': 'warn',
+ '@typescript-eslint/prefer-promise-reject-errors': 'warn',
+ '@typescript-eslint/require-await': 'warn',
+ '@typescript-eslint/restrict-template-expressions': 'warn',
+ '@typescript-eslint/unbound-method': 'warn',
- // The following rules are part of @typescript-eslint/stylistic-type-checked
- // and can be remove once solved
- '@typescript-eslint/prefer-nullish-coalescing': 'warn' // TODO: Requires strictNullChecks: true
- }
- }))
+ // The following rules are part of @typescript-eslint/stylistic-type-checked
+ // and can be remove once solved
+ '@typescript-eslint/prefer-nullish-coalescing': 'warn' // TODO: Requires strictNullChecks: true
+ }
+ })
];
diff --git a/libs/ui/eslint.config.cjs b/libs/ui/eslint.config.cjs
index b7aeb37e03..70a725c528 100644
--- a/libs/ui/eslint.config.cjs
+++ b/libs/ui/eslint.config.cjs
@@ -2,7 +2,7 @@ const baseConfig = require('../../eslint.config.cjs');
const angularEslintPlugin = require('@angular-eslint/eslint-plugin');
const angularTemplateEslintPlugin = require('@angular-eslint/eslint-plugin-template');
const angularTemplateParser = require('@angular-eslint/template-parser');
-const typescriptEslintPlugin = require('@typescript-eslint/eslint-plugin');
+const typescriptEslintPlugin = require('typescript-eslint').plugin;
module.exports = [
{
diff --git a/package-lock.json b/package-lock.json
index 0bccf99a2b..c4896f0436 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -122,7 +122,6 @@
"@angular/language-service": "22.1.2",
"@angular/localize": "22.1.2",
"@angular/pwa": "22.1.4",
- "@eslint/eslintrc": "3.3.1",
"@eslint/js": "9.35.0",
"@nestjs/schematics": "11.1.0",
"@nestjs/testing": "11.2.3",
@@ -177,6 +176,7 @@
"ts-node": "10.9.2",
"tslib": "2.8.1",
"typescript": "6.0.3",
+ "typescript-eslint": "8.67.0",
"webpack-cli": "7.1.0"
},
"engines": {
@@ -34933,6 +34933,30 @@
"node": ">=14.17"
}
},
+ "node_modules/typescript-eslint": {
+ "version": "8.67.0",
+ "resolved": "https://registry.npmjs.org/typescript-eslint/-/typescript-eslint-8.67.0.tgz",
+ "integrity": "sha512-S2udFs8tCKEKffuJ4TB1idGUZiXdCPGi3IPBGWXarbLQ5UPXORV8QEVzJ4gCRduURMb5EkpNCdjbk0eDIuI8Yg==",
+ "dev": true,
+ "license": "MIT",
+ "dependencies": {
+ "@typescript-eslint/eslint-plugin": "8.67.0",
+ "@typescript-eslint/parser": "8.67.0",
+ "@typescript-eslint/typescript-estree": "8.67.0",
+ "@typescript-eslint/utils": "8.67.0"
+ },
+ "engines": {
+ "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
+ },
+ "funding": {
+ "type": "opencollective",
+ "url": "https://opencollective.com/typescript-eslint"
+ },
+ "peerDependencies": {
+ "eslint": "^8.57.0 || ^9.0.0 || ^10.0.0",
+ "typescript": ">=4.8.4 <6.1.0"
+ }
+ },
"node_modules/uglify-js": {
"version": "3.19.3",
"resolved": "https://registry.npmjs.org/uglify-js/-/uglify-js-3.19.3.tgz",
diff --git a/package.json b/package.json
index bb1c66a955..3361c354ba 100644
--- a/package.json
+++ b/package.json
@@ -166,7 +166,6 @@
"@angular/language-service": "22.1.2",
"@angular/localize": "22.1.2",
"@angular/pwa": "22.1.4",
- "@eslint/eslintrc": "3.3.1",
"@eslint/js": "9.35.0",
"@nestjs/schematics": "11.1.0",
"@nestjs/testing": "11.2.3",
@@ -221,6 +220,7 @@
"ts-node": "10.9.2",
"tslib": "2.8.1",
"typescript": "6.0.3",
+ "typescript-eslint": "8.67.0",
"webpack-cli": "7.1.0"
},
"engines": {