Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/improve style of placeholder in entity logo component (#7572)

Thomas Kaul1d948c32862b
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 663fdd1fe0..cf25a0b98b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the check for duplicates in the preview step of the import dividends dialog (regardless of the account)
- Extended the activities import to reuse an existing account of the user by name and currency
- Extended the activities import to resolve an ISIN to the symbol of the data provider
+- Improved the style of the placeholder in the entity logo component
- Migrated the create, detail and edit account dialogs to dedicated routes
- Improved the language localization for German (`de`)
diff --git a/libs/ui/src/lib/entity-logo/entity-logo.component.html b/libs/ui/src/lib/entity-logo/entity-logo.component.html
index 0a7ecbcd20..fe58f8226c 100644
--- a/libs/ui/src/lib/entity-logo/entity-logo.component.html
+++ b/libs/ui/src/lib/entity-logo/entity-logo.component.html
@@ -7,5 +7,5 @@
(error)="onError()"
/>
} @else if (hasPlaceholder) {
- <div class="logo placeholder" [class.large]="size === 'large'"></div>
+ <div class="logo" [class.large]="size === 'large'"></div>
}
diff --git a/libs/ui/src/lib/entity-logo/entity-logo.component.scss b/libs/ui/src/lib/entity-logo/entity-logo.component.scss
index 0511993468..9f2ccf73d6 100644
--- a/libs/ui/src/lib/entity-logo/entity-logo.component.scss
+++ b/libs/ui/src/lib/entity-logo/entity-logo.component.scss
@@ -11,15 +11,5 @@
height: 1.4rem;
width: 1.4rem;
}
-
- &.placeholder {
- border: 1px solid rgba(var(--dark-dividers));
- }
- }
-}
-
-:host-context(.theme-dark) {
- .placeholder {
- border-color: rgba(var(--light-dividers));
}
}
diff --git a/libs/ui/src/lib/entity-logo/entity-logo.component.stories.ts b/libs/ui/src/lib/entity-logo/entity-logo.component.stories.ts
index 786d54cbf4..9c977eca5a 100644
--- a/libs/ui/src/lib/entity-logo/entity-logo.component.stories.ts
+++ b/libs/ui/src/lib/entity-logo/entity-logo.component.stories.ts
@@ -45,18 +45,17 @@ export const LogoByUrl: Story = {
}
};
-export const Placeholder: Story = {
+export const LogoOnError: Story = {
args: {
- hasPlaceholder: true,
- size: 'large'
+ size: 'large',
+ tooltip: 'Unknown',
+ url: 'https://unknown.ghostfol.io'
}
};
-export const PlaceholderOnError: Story = {
+export const Placeholder: Story = {
args: {
hasPlaceholder: true,
- size: 'large',
- tooltip: 'Unknown',
- url: 'https://unknown.ghostfol.io'
+ size: 'large'
}
};