Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Refactor getCashPositions() in portfolio service (#4800)

Thomas Kaul1dd385761877
diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index 9f1901c7fd..eb6abc224f 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -542,7 +542,7 @@ export class PortfolioService {
}
if (filters?.length === 0 || isFilteredByAccount || isFilteredByCash) {
- const cashPositions = await this.getCashPositions({
+ const cashPositions = this.getCashPositions({
cashDetails,
userCurrency,
value: filteredValueInBaseCurrency
@@ -567,7 +567,7 @@ export class PortfolioService {
filters[0].id === TAG_ID_EMERGENCY_FUND &&
filters[0].type === 'TAG'
) {
- const emergencyFundCashPositions = await this.getCashPositions({
+ const emergencyFundCashPositions = this.getCashPositions({
cashDetails,
userCurrency,
value: filteredValueInBaseCurrency
@@ -1535,7 +1535,7 @@ export class PortfolioService {
return { markets, marketsAdvanced };
}
- private async getCashPositions({
+ private getCashPositions({
cashDetails,
userCurrency,
value