Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/move countries and sectors chart (#704)

Thomas Kaul1eb4041837fd
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 44bc6ec12a..b266833e84 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+## Unreleased
+
+### Changed
+
+- Moved the countries and sectors charts in the position detail dialog
+
## 1.116.0 - 16.02.2022
### Added
diff --git a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
index e641a8f1fe..9ea26573f0 100644
--- a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
+++ b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
@@ -144,6 +144,14 @@
<ng-container
*ngIf="SymbolProfile?.countries?.length === 1 && SymbolProfile?.sectors?.length === 1; else charts"
>
+ <div *ngIf="SymbolProfile?.sectors?.length === 1" class="col-6 mb-3">
+ <gf-value
+ label="Sector"
+ size="medium"
+ [locale]="data.locale"
+ [value]="SymbolProfile.sectors[0].name"
+ ></gf-value>
+ </div>
<div
*ngIf="SymbolProfile?.countries?.length === 1"
class="col-6 mb-3"
@@ -155,36 +163,28 @@
[value]="SymbolProfile.countries[0].name"
></gf-value>
</div>
- <div *ngIf="SymbolProfile?.sectors?.length === 1" class="col-6 mb-3">
- <gf-value
- label="Sector"
- size="medium"
- [locale]="data.locale"
- [value]="SymbolProfile.sectors[0].name"
- ></gf-value>
- </div>
</ng-container>
<ng-template #charts>
<div class="col-md-6 mb-3">
- <div class="h4" i18n>Countries</div>
+ <div class="h4" i18n>Sectors</div>
<gf-portfolio-proportion-chart
[baseCurrency]="user?.settings?.baseCurrency"
[isInPercent]="true"
[keys]="['name']"
[locale]="user?.settings?.locale"
[maxItems]="10"
- [positions]="countries"
+ [positions]="sectors"
></gf-portfolio-proportion-chart>
</div>
<div class="col-md-6 mb-3">
- <div class="h4" i18n>Sectors</div>
+ <div class="h4" i18n>Countries</div>
<gf-portfolio-proportion-chart
[baseCurrency]="user?.settings?.baseCurrency"
[isInPercent]="true"
[keys]="['name']"
[locale]="user?.settings?.locale"
[maxItems]="10"
- [positions]="sectors"
+ [positions]="countries"
></gf-portfolio-proportion-chart>
</div>
</ng-template>