Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/always show label in value component (#1812)

Thomas Kaul1f3511368a3a
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ad96fde423..70061ac8de 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Unreleased
+### Changed
+
+- Improved the value component by always showing the label (also while loading)
+
### Fixed
- Fixed an issue with the algebraic sign in the value component
diff --git a/libs/ui/src/lib/value/value.component.html b/libs/ui/src/lib/value/value.component.html
index 790d99a4ef..35be5b8083 100644
--- a/libs/ui/src/lib/value/value.component.html
+++ b/libs/ui/src/lib/value/value.component.html
@@ -48,17 +48,6 @@
</div>
</ng-container>
</div>
- <ng-container>
- <div *ngIf="size === 'large'">
- <span class="h6"
- ><ng-container *ngTemplateOutlet="label"></ng-container
- ></span>
- <span *ngIf="subLabel" class="text-muted"> {{ subLabel }}</span>
- </div>
- <small *ngIf="size !== 'large'">
- <ng-container *ngTemplateOutlet="label"></ng-container>
- </small>
- </ng-container>
</ng-container>
<ngx-skeleton-loader
@@ -66,8 +55,20 @@
animation="pulse"
[theme]="{
height:
- size === 'large' ? '2.5rem' : size === 'medium' ? '2rem' : '1.5rem',
+ size === 'large' ? '2rem' : size === 'medium' ? '1.8rem' : '1.5rem',
width: '5rem'
}"
></ngx-skeleton-loader>
+
+ <ng-container>
+ <div *ngIf="size === 'large'">
+ <span class="h6"
+ ><ng-container *ngTemplateOutlet="label"></ng-container
+ ></span>
+ <span *ngIf="subLabel" class="text-muted"> {{ subLabel }}</span>
+ </div>
+ <small *ngIf="size !== 'large'">
+ <ng-container *ngTemplateOutlet="label"></ng-container>
+ </small>
+ </ng-container>
</div>