Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Improve logging (#3304)

Thomas Kaul22d63c610264
diff --git a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts
index a02ddb597d..683002a101 100644
--- a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts
+++ b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts
@@ -449,13 +449,16 @@ export class ExchangeRateDataService {
factors[format(date, DATE_FORMAT)] = factor;
}
} catch {
- Logger.error(
- `No exchange rate has been found for ${currencyFrom}${currencyTo} at ${format(
- date,
- DATE_FORMAT
- )}. Please complement market data for ${DEFAULT_CURRENCY}${currencyFrom} and ${DEFAULT_CURRENCY}${currencyTo}.`,
- 'ExchangeRateDataService'
- );
+ let errorMessage = `No exchange rate has been found for ${currencyFrom}${currencyTo} at ${format(
+ date,
+ DATE_FORMAT
+ )}. Please complement market data for ${DEFAULT_CURRENCY}${currencyFrom}`;
+
+ if (DEFAULT_CURRENCY !== currencyTo) {
+ errorMessage = `${errorMessage} and ${DEFAULT_CURRENCY}${currencyTo}`;
+ }
+
+ Logger.error(`${errorMessage}.`, 'ExchangeRateDataService');
}
}
}