Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/improve typings of getInfo() functionality (#5803)

vitalymatyushik24234591c90e
diff --git a/apps/api/src/app/info/info.controller.ts b/apps/api/src/app/info/info.controller.ts
index 67d4101a3e..7011713dda 100644
--- a/apps/api/src/app/info/info.controller.ts
+++ b/apps/api/src/app/info/info.controller.ts
@@ -1,5 +1,5 @@
import { TransformDataSourceInResponseInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-response/transform-data-source-in-response.interceptor';
-import { InfoItem } from '@ghostfolio/common/interfaces';
+import { InfoResponse } from '@ghostfolio/common/interfaces';
import { Controller, Get, UseInterceptors } from '@nestjs/common';
@@ -11,7 +11,7 @@ export class InfoController {
@Get()
@UseInterceptors(TransformDataSourceInResponseInterceptor)
- public async getInfo(): Promise<InfoItem> {
+ public async getInfo(): Promise<InfoResponse> {
return this.infoService.get();
}
}
diff --git a/apps/client/src/main.ts b/apps/client/src/main.ts
index 2f656ddf28..96d6c05827 100644
--- a/apps/client/src/main.ts
+++ b/apps/client/src/main.ts
@@ -1,5 +1,5 @@
import { locale } from '@ghostfolio/common/config';
-import { InfoItem } from '@ghostfolio/common/interfaces';
+import { InfoResponse } from '@ghostfolio/common/interfaces';
import { filterGlobalPermissions } from '@ghostfolio/common/permissions';
import { enableProdMode } from '@angular/core';
@@ -11,7 +11,7 @@ import { environment } from './environments/environment';
(async () => {
const response = await fetch('/api/v1/info');
- const info: InfoItem = await response.json();
+ const info: InfoResponse = await response.json();
const utmSource = window.localStorage.getItem('utm_source') as
| 'ios'
| 'trusted-web-activity';
diff --git a/libs/common/src/lib/interfaces/index.ts b/libs/common/src/lib/interfaces/index.ts
index 578d9cec8f..b69891e311 100644
--- a/libs/common/src/lib/interfaces/index.ts
+++ b/libs/common/src/lib/interfaces/index.ts
@@ -50,6 +50,7 @@ import type { DividendsResponse } from './responses/dividends-response.interface
import type { ResponseError } from './responses/errors.interface';
import type { HistoricalResponse } from './responses/historical-response.interface';
import type { ImportResponse } from './responses/import-response.interface';
+import type { InfoResponse } from './responses/info-response.interface';
import type { LookupResponse } from './responses/lookup-response.interface';
import type { MarketDataDetailsResponse } from './responses/market-data-details-response.interface';
import type { MarketDataOfMarketsResponse } from './responses/market-data-of-markets-response.interface';
@@ -112,6 +113,7 @@ export {
HoldingWithParents,
ImportResponse,
InfoItem,
+ InfoResponse,
InvestmentItem,
LineChartItem,
LookupItem,
diff --git a/libs/common/src/lib/interfaces/responses/info-response.interface.ts b/libs/common/src/lib/interfaces/responses/info-response.interface.ts
new file mode 100644
index 0000000000..45e62db73b
--- /dev/null
+++ b/libs/common/src/lib/interfaces/responses/info-response.interface.ts
@@ -0,0 +1,3 @@
+import { InfoItem } from '../index';
+
+export interface InfoResponse extends InfoItem {}