Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/remove holdings with incomplete data from top3 bottom3 performers (#2921)

Thomas Kaul2c10cd7edfc7
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 16fa6c9385..6752784fa0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the language localization for German (`de`)
+### Fixed
+
+- Removed holdings with incomplete data from the _Top 3_ and _Bottom 3_ performers on the analysis page
+
## 2.44.0 - 2024-01-24
### Fixed
diff --git a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
index 7fd5b342d2..f0fb33665d 100644
--- a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
+++ b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
@@ -379,7 +379,9 @@ export class AnalysisPageComponent implements OnDestroy, OnInit {
.pipe(takeUntil(this.unsubscribeSubject))
.subscribe(({ positions }) => {
const positionsSorted = sortBy(
- positions,
+ positions.filter(({ netPerformancePercentage }) => {
+ return isNumber(netPerformancePercentage);
+ }),
'netPerformancePercentage'
).reverse();