Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Task/eliminate OnDestroy lifecycle hook from create watchlist item dialog component (#6676)
Erwin2cdfeb84d676
diff --git a/apps/client/src/app/components/home-watchlist/create-watchlist-item-dialog/create-watchlist-item-dialog.component.ts b/apps/client/src/app/components/home-watchlist/create-watchlist-item-dialog/create-watchlist-item-dialog.component.tsindex 60d74be927..4669a827da 100644--- a/apps/client/src/app/components/home-watchlist/create-watchlist-item-dialog/create-watchlist-item-dialog.component.ts+++ b/apps/client/src/app/components/home-watchlist/create-watchlist-item-dialog/create-watchlist-item-dialog.component.ts@@ -1,11 +1,6 @@import { GfSymbolAutocompleteComponent } from '@ghostfolio/ui/symbol-autocomplete';-import {- ChangeDetectionStrategy,- Component,- OnDestroy,- OnInit-} from '@angular/core';+import { ChangeDetectionStrategy, Component, OnInit } from '@angular/core';import {AbstractControl,FormBuilder,@@ -19,7 +14,6 @@ import {import { MatButtonModule } from '@angular/material/button';import { MatDialogModule, MatDialogRef } from '@angular/material/dialog';import { MatFormFieldModule } from '@angular/material/form-field';-import { Subject } from 'rxjs';@Component({changeDetection: ChangeDetectionStrategy.OnPush,@@ -36,11 +30,9 @@ import { Subject } from 'rxjs';styleUrls: ['./create-watchlist-item-dialog.component.scss'],templateUrl: 'create-watchlist-item-dialog.html'})-export class GfCreateWatchlistItemDialogComponent implements OnDestroy, OnInit {+export class GfCreateWatchlistItemDialogComponent implements OnInit {public createWatchlistItemForm: FormGroup;- private unsubscribeSubject = new Subject<void>();-public constructor(public readonly dialogRef: MatDialogRef<GfCreateWatchlistItemDialogComponent>,public readonly formBuilder: FormBuilder@@ -69,11 +61,6 @@ export class GfCreateWatchlistItemDialogComponent implements OnDestroy, OnInit {});}- public ngOnDestroy() {- this.unsubscribeSubject.next();- this.unsubscribeSubject.complete();- }-private validator(control: AbstractControl): ValidationErrors {const searchSymbolControl = control.get('searchSymbol');