Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/refactor getDividends() from async to sync (#6222)

Thomas Kaul30be7589b6db
diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts
index 03796dad64..a5a1d95ee4 100644
--- a/apps/api/src/app/portfolio/portfolio.controller.ts
+++ b/apps/api/src/app/portfolio/portfolio.controller.ts
@@ -329,7 +329,7 @@ export class PortfolioController {
types: ['DIVIDEND']
});
- let dividends = await this.portfolioService.getDividends({
+ let dividends = this.portfolioService.getDividends({
activities,
groupBy
});
diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index 20016e67fd..7db743a43d 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -325,13 +325,13 @@ export class PortfolioService {
};
}
- public async getDividends({
+ public getDividends({
activities,
groupBy
}: {
activities: Activity[];
groupBy?: GroupBy;
- }): Promise<InvestmentItem[]> {
+ }): InvestmentItem[] {
let dividends = activities.map(({ currency, date, value }) => {
return {
date: format(date, DATE_FORMAT),