Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/extend get historical in financial modeling prep service (#4229)

Thomas Kaul39ac6f352fe4
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3aaa47b745..f75a63fc69 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
+- Extended the _Financial Modeling Prep_ service
- Improved the language localization for Ukrainian (`uk`)
- Upgraded `date-fns` from version `3.6.0` to `4.1.0`
- Upgraded `rxjs` from version `7.5.6` to `7.8.1`
diff --git a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts
index ac6b5822e5..c7550080b9 100644
--- a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts
+++ b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts
@@ -29,6 +29,7 @@ import { isISIN } from 'class-validator';
import { countries } from 'countries-list';
import {
addDays,
+ addYears,
format,
isAfter,
isBefore,
@@ -273,30 +274,44 @@ export class FinancialModelingPrepService implements DataProviderInterface {
}: GetHistoricalParams): Promise<{
[symbol: string]: { [date: string]: IDataProviderHistoricalResponse };
}> {
+ const MAX_YEARS_PER_REQUEST = 5;
+ const result: {
+ [symbol: string]: { [date: string]: IDataProviderHistoricalResponse };
+ } = {
+ [symbol]: {}
+ };
+
+ let currentFrom = from;
+
try {
- const { historical } = await fetch(
- `${this.URL}/historical-price-full/${symbol}?apikey=${this.apiKey}`,
- {
- signal: AbortSignal.timeout(requestTimeout)
- }
- ).then((res) => res.json());
+ while (isBefore(currentFrom, to) || isSameDay(currentFrom, to)) {
+ const currentTo = isBefore(
+ addYears(currentFrom, MAX_YEARS_PER_REQUEST),
+ to
+ )
+ ? addYears(currentFrom, MAX_YEARS_PER_REQUEST)
+ : to;
+
+ const { historical } = await fetch(
+ `${this.URL}/historical-price-full/${symbol}?apikey=${this.apiKey}&from=${format(currentFrom, DATE_FORMAT)}&to=${format(currentTo, DATE_FORMAT)}`,
+ {
+ signal: AbortSignal.timeout(requestTimeout)
+ }
+ ).then((res) => res.json());
- const result: {
- [symbol: string]: { [date: string]: IDataProviderHistoricalResponse };
- } = {
- [symbol]: {}
- };
-
- for (const { adjClose, date } of historical) {
- if (
- (isSameDay(parseDate(date), from) ||
- isAfter(parseDate(date), from)) &&
- isBefore(parseDate(date), to)
- ) {
- result[symbol][date] = {
- marketPrice: adjClose
- };
+ for (const { adjClose, date } of historical) {
+ if (
+ (isSameDay(parseDate(date), currentFrom) ||
+ isAfter(parseDate(date), currentFrom)) &&
+ isBefore(parseDate(date), currentTo)
+ ) {
+ result[symbol][date] = {
+ marketPrice: adjClose
+ };
+ }
}
+
+ currentFrom = addYears(currentFrom, MAX_YEARS_PER_REQUEST);
}
return result;