Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/improve performance of historical market data query (#8061)

Thomas Kaul3ecf11bb984a
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a98179b3d2..73b61f15c0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Extended the benchmark comparator to support benchmarks whose market data starts later than the portfolio
- Harmonized the colors in the investment chart component
+- Improved the performance of getting the historical market data by loading only the requested asset profiles
- Improved the language localization for Chinese (`zh`)
### Fixed
diff --git a/apps/api/src/services/data-provider/data-provider.service.ts b/apps/api/src/services/data-provider/data-provider.service.ts
index cfacab3231..7bd06b1c99 100644
--- a/apps/api/src/services/data-provider/data-provider.service.ts
+++ b/apps/api/src/services/data-provider/data-provider.service.ts
@@ -403,12 +403,8 @@ export class DataProviderService implements OnModuleInit {
})}::timestamp`
: Prisma.empty;
- const dataSources = aItems.map(({ dataSource }) => {
- return dataSource;
- });
-
- const symbols = aItems.map(({ symbol }) => {
- return symbol;
+ const assetProfileIdentifiers = aItems.map(({ dataSource, symbol }) => {
+ return Prisma.sql`(${dataSource}::"DataSource", ${symbol})`;
});
try {
@@ -416,8 +412,7 @@ export class DataProviderService implements OnModuleInit {
.$queryRaw`
SELECT *
FROM "MarketData"
- WHERE "dataSource"::text IN (${Prisma.join(dataSources)})
- AND "symbol" IN (${Prisma.join(symbols)})
+ WHERE ("dataSource", "symbol") IN (${Prisma.join(assetProfileIdentifiers)})
${granularityQuery}
${rangeQuery}
ORDER BY date;`;