Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/migrate file drop directive to standalone (#5646)

SK Akram3f2d045e1fcd
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5047e97bbf..524dcc47b9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the usability of the _Cancel_ / _Close_ buttons in the create watchlist item dialog
- Refactored the `fireWealth` from `number` type to a structured object in the summary of the portfolio details endpoint
- Refactored the _Open Startup_ (`/open`) page to standalone
+- Refactored the file drop directive to standalone
- Refactored the symbol pipe to standalone
### Fixed
diff --git a/apps/client/src/app/directives/file-drop/file-drop.directive.ts b/apps/client/src/app/directives/file-drop/file-drop.directive.ts
index 93f444572b..a7e628bc9f 100644
--- a/apps/client/src/app/directives/file-drop/file-drop.directive.ts
+++ b/apps/client/src/app/directives/file-drop/file-drop.directive.ts
@@ -1,10 +1,9 @@
import { Directive, EventEmitter, HostListener, Output } from '@angular/core';
@Directive({
- selector: '[gfFileDrop]',
- standalone: false
+ selector: '[gfFileDrop]'
})
-export class FileDropDirective {
+export class GfFileDropDirective {
@Output() filesDropped = new EventEmitter<FileList>();
@HostListener('dragenter', ['$event']) onDragEnter(event: DragEvent) {
diff --git a/apps/client/src/app/directives/file-drop/file-drop.module.ts b/apps/client/src/app/directives/file-drop/file-drop.module.ts
deleted file mode 100644
index a0148516e6..0000000000
--- a/apps/client/src/app/directives/file-drop/file-drop.module.ts
+++ /dev/null
@@ -1,9 +0,0 @@
-import { NgModule } from '@angular/core';
-
-import { FileDropDirective } from './file-drop.directive';
-
-@NgModule({
- declarations: [FileDropDirective],
- exports: [FileDropDirective]
-})
-export class GfFileDropModule {}
diff --git a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts
index db581bcd8d..d1eaf0fe1b 100644
--- a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts
+++ b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts
@@ -4,7 +4,7 @@ import { CreateAssetProfileWithMarketDataDto } from '@ghostfolio/api/app/import/
import { Activity } from '@ghostfolio/api/app/order/interfaces/activities.interface';
import { GfDialogFooterComponent } from '@ghostfolio/client/components/dialog-footer/dialog-footer.component';
import { GfDialogHeaderComponent } from '@ghostfolio/client/components/dialog-header/dialog-header.component';
-import { GfFileDropModule } from '@ghostfolio/client/directives/file-drop/file-drop.module';
+import { GfFileDropDirective } from '@ghostfolio/client/directives/file-drop/file-drop.directive';
import { GfSymbolPipe } from '@ghostfolio/client/pipes/symbol/symbol.pipe';
import { DataService } from '@ghostfolio/client/services/data.service';
import { ImportActivitiesService } from '@ghostfolio/client/services/import-activities.service';
@@ -62,7 +62,7 @@ import { ImportActivitiesDialogParams } from './interfaces/interfaces';
GfActivitiesTableComponent,
GfDialogFooterComponent,
GfDialogHeaderComponent,
- GfFileDropModule,
+ GfFileDropDirective,
GfSymbolPipe,
IonIcon,
MatButtonModule,