Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/improve validation for currency in endpoints (#3030)

Thomas Kaul40836b745b11
diff --git a/CHANGELOG.md b/CHANGELOG.md
index b9648e42ad..2fd0160933 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
+- Improved the validation for `currency` in various endpoints
- Harmonized the setting of a default locale in various components
- Set the parser to `angular` in the `prettier` options
diff --git a/apps/api/src/app/account/create-account.dto.ts b/apps/api/src/app/account/create-account.dto.ts
index a6e07ad825..b719c2619c 100644
--- a/apps/api/src/app/account/create-account.dto.ts
+++ b/apps/api/src/app/account/create-account.dto.ts
@@ -1,6 +1,7 @@
import { Transform, TransformFnParams } from 'class-transformer';
import {
IsBoolean,
+ IsISO4217CurrencyCode,
IsNumber,
IsOptional,
IsString,
@@ -19,7 +20,7 @@ export class CreateAccountDto {
)
comment?: string;
- @IsString()
+ @IsISO4217CurrencyCode()
currency: string;
@IsOptional()
diff --git a/apps/api/src/app/account/update-account.dto.ts b/apps/api/src/app/account/update-account.dto.ts
index 16d55386d5..1b84a9bf6f 100644
--- a/apps/api/src/app/account/update-account.dto.ts
+++ b/apps/api/src/app/account/update-account.dto.ts
@@ -1,6 +1,7 @@
import { Transform, TransformFnParams } from 'class-transformer';
import {
IsBoolean,
+ IsISO4217CurrencyCode,
IsNumber,
IsOptional,
IsString,
@@ -19,7 +20,7 @@ export class UpdateAccountDto {
)
comment?: string;
- @IsString()
+ @IsISO4217CurrencyCode()
currency: string;
@IsString()
diff --git a/apps/api/src/app/admin/update-asset-profile.dto.ts b/apps/api/src/app/admin/update-asset-profile.dto.ts
index 624acff9f2..4a04571949 100644
--- a/apps/api/src/app/admin/update-asset-profile.dto.ts
+++ b/apps/api/src/app/admin/update-asset-profile.dto.ts
@@ -2,6 +2,7 @@ import { AssetClass, AssetSubClass, Prisma } from '@prisma/client';
import {
IsArray,
IsEnum,
+ IsISO4217CurrencyCode,
IsObject,
IsOptional,
IsString
@@ -24,7 +25,7 @@ export class UpdateAssetProfileDto {
@IsOptional()
countries?: Prisma.InputJsonArray;
- @IsString()
+ @IsISO4217CurrencyCode()
@IsOptional()
currency?: string;
diff --git a/apps/api/src/app/order/create-order.dto.ts b/apps/api/src/app/order/create-order.dto.ts
index f25a7ee121..aecec842a8 100644
--- a/apps/api/src/app/order/create-order.dto.ts
+++ b/apps/api/src/app/order/create-order.dto.ts
@@ -10,6 +10,7 @@ import {
IsArray,
IsBoolean,
IsEnum,
+ IsISO4217CurrencyCode,
IsISO8601,
IsNumber,
IsOptional,
@@ -38,7 +39,7 @@ export class CreateOrderDto {
)
comment?: string;
- @IsString()
+ @IsISO4217CurrencyCode()
currency: string;
@IsOptional()
diff --git a/apps/api/src/app/order/update-order.dto.ts b/apps/api/src/app/order/update-order.dto.ts
index 3123d5665e..c0a400c570 100644
--- a/apps/api/src/app/order/update-order.dto.ts
+++ b/apps/api/src/app/order/update-order.dto.ts
@@ -9,6 +9,7 @@ import { Transform, TransformFnParams } from 'class-transformer';
import {
IsArray,
IsEnum,
+ IsISO4217CurrencyCode,
IsISO8601,
IsNumber,
IsOptional,
@@ -37,7 +38,7 @@ export class UpdateOrderDto {
)
comment?: string;
- @IsString()
+ @IsISO4217CurrencyCode()
currency: string;
@IsString()
diff --git a/apps/api/src/app/user/update-user-setting.dto.ts b/apps/api/src/app/user/update-user-setting.dto.ts
index 317a31527c..7b09ced102 100644
--- a/apps/api/src/app/user/update-user-setting.dto.ts
+++ b/apps/api/src/app/user/update-user-setting.dto.ts
@@ -7,6 +7,7 @@ import type {
import {
IsArray,
IsBoolean,
+ IsISO4217CurrencyCode,
IsISO8601,
IsIn,
IsNumber,
@@ -19,8 +20,8 @@ export class UpdateUserSettingDto {
@IsOptional()
annualInterestRate?: number;
+ @IsISO4217CurrencyCode()
@IsOptional()
- @IsString()
baseCurrency?: string;
@IsString()