Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/coupon validation in Stripe checkout session (#7877)

Thomas Kaul46d060df1b85
diff --git a/apps/api/src/app/subscription/subscription.service.ts b/apps/api/src/app/subscription/subscription.service.ts
index 312b8c3aef..f5acbc3e33 100644
--- a/apps/api/src/app/subscription/subscription.service.ts
+++ b/apps/api/src/app/subscription/subscription.service.ts
@@ -58,17 +58,23 @@ export class SubscriptionService {
} =
(await this.propertyService.getByKey<any>(PROPERTY_STRIPE_CONFIG)) ?? {};
- const subscriptionOffer = Object.values(subscriptionOffers).find(
+ const subscriptionOffersForPrice = Object.values(subscriptionOffers).filter(
(subscriptionOffer) => {
return subscriptionOffer.priceId === priceId;
}
);
- if (!subscriptionOffer) {
+ if (subscriptionOffersForPrice.length === 0) {
throw new BadRequestException('Invalid priceId');
}
- if (couponId && couponId !== subscriptionOffer.couponId) {
+ const subscriptionOffer = subscriptionOffersForPrice.find(
+ (subscriptionOffer) => {
+ return subscriptionOffer.couponId === couponId;
+ }
+ );
+
+ if (!subscriptionOffer) {
throw new BadRequestException('Invalid couponId');
}