Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/fix division by zero error in dividend yield calculation (#3354)

Thomas Kaul486de968a213
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 50e732acb4..8b3bdbbac0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed an issue in the calculation of the portfolio summary caused by future liabilities
+- Fixed a division by zero error in the dividend yield calculation (experimental)
## 2.77.1 - 2024-04-27
diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index 61906982bf..10c09a21f6 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -704,17 +704,19 @@ export class PortfolioService {
const dividendYieldPercent = this.getAnnualizedPerformancePercent({
daysInMarket: differenceInDays(new Date(), parseDate(firstBuyDate)),
- netPerformancePercent: dividendInBaseCurrency.div(
- timeWeightedInvestment
- )
+ netPerformancePercent: timeWeightedInvestment.eq(0)
+ ? new Big(0)
+ : dividendInBaseCurrency.div(timeWeightedInvestment)
});
const dividendYieldPercentWithCurrencyEffect =
this.getAnnualizedPerformancePercent({
daysInMarket: differenceInDays(new Date(), parseDate(firstBuyDate)),
- netPerformancePercent: dividendInBaseCurrency.div(
- timeWeightedInvestmentWithCurrencyEffect
- )
+ netPerformancePercent: timeWeightedInvestmentWithCurrencyEffect.eq(0)
+ ? new Big(0)
+ : dividendInBaseCurrency.div(
+ timeWeightedInvestmentWithCurrencyEffect
+ )
});
const historicalData = await this.dataProviderService.getHistorical(