Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/add date of first activity to holdings (#1505)

Thomas Kaul49dcade964d3
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 87015d7627..acdd804cca 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Unreleased
+### Added
+
+- Added the date of the first activity to the positions table
+
### Changed
- Improved the asset profile details dialog in the admin control panel
diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts
index a0f676ff65..46f5556405 100644
--- a/apps/api/src/app/portfolio/portfolio.controller.ts
+++ b/apps/api/src/app/portfolio/portfolio.controller.ts
@@ -422,6 +422,7 @@ export class PortfolioController {
allocationCurrent: portfolioPosition.value / totalValue,
countries: hasDetails ? portfolioPosition.countries : [],
currency: hasDetails ? portfolioPosition.currency : undefined,
+ dateOfFirstActivity: portfolioPosition.dateOfFirstActivity,
markets: hasDetails ? portfolioPosition.markets : undefined,
name: portfolioPosition.name,
netPerformancePercent: portfolioPosition.netPerformancePercent,
diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index 0db7d58131..a8c26afa4c 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -533,6 +533,7 @@ export class PortfolioService {
countries: symbolProfile.countries,
currency: item.currency,
dataSource: symbolProfile.dataSource,
+ dateOfFirstActivity: parseDate(item.firstBuyDate),
grossPerformance: item.grossPerformance?.toNumber() ?? 0,
grossPerformancePercent:
item.grossPerformancePercentage?.toNumber() ?? 0,
@@ -1329,6 +1330,7 @@ export class PortfolioService {
assetSubClass: AssetClass.CASH,
countries: [],
dataSource: undefined,
+ dateOfFirstActivity: undefined,
grossPerformance: 0,
grossPerformancePercent: 0,
investment: balance,
diff --git a/apps/client/src/app/components/positions-table/positions-table.component.html b/apps/client/src/app/components/positions-table/positions-table.component.html
index 3f9a0cb4f6..cb72cddb43 100644
--- a/apps/client/src/app/components/positions-table/positions-table.component.html
+++ b/apps/client/src/app/components/positions-table/positions-table.component.html
@@ -42,6 +42,26 @@
</td>
</ng-container>
+ <ng-container matColumnDef="dateOfFirstActivity">
+ <th
+ *matHeaderCellDef
+ class="d-none d-lg-table-cell justify-content-end px-1"
+ mat-header-cell
+ mat-sort-header
+ >
+ <ng-container i18n>First Activity</ng-container>
+ </th>
+ <td *matCellDef="let element" class="d-none d-lg-table-cell px-1" mat-cell>
+ <div class="d-flex justify-content-end">
+ <gf-value
+ [isDate]="element.dateOfFirstActivity ? true : false"
+ [locale]="locale"
+ [value]="element.dateOfFirstActivity ?? ''"
+ ></gf-value>
+ </div>
+ </td>
+ </ng-container>
+
<ng-container matColumnDef="value">
<th
*matHeaderCellDef
diff --git a/apps/client/src/app/components/positions-table/positions-table.component.ts b/apps/client/src/app/components/positions-table/positions-table.component.ts
index acd76ef11c..c14c20bce0 100644
--- a/apps/client/src/app/components/positions-table/positions-table.component.ts
+++ b/apps/client/src/app/components/positions-table/positions-table.component.ts
@@ -56,7 +56,7 @@ export class PositionsTableComponent implements OnChanges, OnDestroy, OnInit {
public ngOnInit() {}
public ngOnChanges() {
- this.displayedColumns = ['icon', 'symbol', 'name'];
+ this.displayedColumns = ['icon', 'symbol', 'name', 'dateOfFirstActivity'];
if (this.hasPermissionToShowValues) {
this.displayedColumns.push('value');
diff --git a/apps/client/src/app/services/data.service.ts b/apps/client/src/app/services/data.service.ts
index 1b831ac906..12c54e181d 100644
--- a/apps/client/src/app/services/data.service.ts
+++ b/apps/client/src/app/services/data.service.ts
@@ -269,6 +269,12 @@ export class DataService {
response.holdings[symbol].assetSubClass = translate(
response.holdings[symbol].assetSubClass
);
+
+ response.holdings[symbol].dateOfFirstActivity = response.holdings[
+ symbol
+ ].dateOfFirstActivity
+ ? parseISO(response.holdings[symbol].dateOfFirstActivity)
+ : undefined;
}
}
diff --git a/libs/common/src/lib/interfaces/portfolio-position.interface.ts b/libs/common/src/lib/interfaces/portfolio-position.interface.ts
index 703d6a6a4c..c0a4288d59 100644
--- a/libs/common/src/lib/interfaces/portfolio-position.interface.ts
+++ b/libs/common/src/lib/interfaces/portfolio-position.interface.ts
@@ -12,6 +12,7 @@ export interface PortfolioPosition {
countries: Country[];
currency: string;
dataSource: DataSource;
+ dateOfFirstActivity: Date;
exchange?: string;
grossPerformance: number;
grossPerformancePercent: number;
diff --git a/libs/common/src/lib/interfaces/portfolio-public-details.interface.ts b/libs/common/src/lib/interfaces/portfolio-public-details.interface.ts
index 6ecb1469a1..6fd63adb9d 100644
--- a/libs/common/src/lib/interfaces/portfolio-public-details.interface.ts
+++ b/libs/common/src/lib/interfaces/portfolio-public-details.interface.ts
@@ -9,6 +9,7 @@ export interface PortfolioPublicDetails {
| 'allocationCurrent'
| 'countries'
| 'currency'
+ | 'dateOfFirstActivity'
| 'markets'
| 'name'
| 'netPerformancePercent'