Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Feature/improve symbol lookup in Trackinsight data enhancer (#4296)
Guillermo Tomás Fernández Martín4f76ee67588b
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 37bc84cf42..db1563f26d 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0### Changed+- Improved the symbol lookup in the _Trackinsight_ data enhancer for asset profile data- Improved the language localization for German (`de`)- Upgraded `@trivago/prettier-plugin-sort-imports` from version `5.2.1` to `5.2.2`diff --git a/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts b/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.tsindex 56b90082d2..2b8eaf2e91 100644--- a/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts+++ b/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts@@ -44,28 +44,31 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {return response;}+ let trackinsightSymbol = await this.searchTrackinsightSymbol({+ requestTimeout,+ symbol+ });++ if (!trackinsightSymbol) {+ trackinsightSymbol = await this.searchTrackinsightSymbol({+ requestTimeout,+ symbol: symbol.split('.')?.[0]+ });+ }++ if (!trackinsightSymbol) {+ return response;+ }+const profile = await fetch(- `${TrackinsightDataEnhancerService.baseUrl}/funds/${symbol}.json`,+ `${TrackinsightDataEnhancerService.baseUrl}/funds/${trackinsightSymbol}.json`,{signal: AbortSignal.timeout(requestTimeout)}).then((res) => res.json()).catch(() => {- return fetch(- `${TrackinsightDataEnhancerService.baseUrl}/funds/${- symbol.split('.')?.[0]- }.json`,- {- signal: AbortSignal.timeout(- this.configurationService.get('REQUEST_TIMEOUT')- )- }- )- .then((res) => res.json())- .catch(() => {- return {};- });+ return {};});const isin = profile?.isin?.split(';')?.[0];@@ -75,29 +78,14 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {}const holdings = await fetch(- `${TrackinsightDataEnhancerService.baseUrl}/holdings/${symbol}.json`,+ `${TrackinsightDataEnhancerService.baseUrl}/holdings/${trackinsightSymbol}.json`,{- signal: AbortSignal.timeout(- this.configurationService.get('REQUEST_TIMEOUT')- )+ signal: AbortSignal.timeout(requestTimeout)}).then((res) => res.json()).catch(() => {- return fetch(- `${TrackinsightDataEnhancerService.baseUrl}/holdings/${- symbol.split('.')?.[0]- }.json`,- {- signal: AbortSignal.timeout(- this.configurationService.get('REQUEST_TIMEOUT')- )- }- )- .then((res) => res.json())- .catch(() => {- return {};- });+ return {};});if (@@ -180,4 +168,33 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {public getTestSymbol() {return 'QQQ';}++ private async searchTrackinsightSymbol({+ requestTimeout,+ symbol+ }: {+ requestTimeout: number;+ symbol: string;+ }) {+ return fetch(+ `https://www.trackinsight.com/search-api/search_v2/${symbol}/_/ticker/default/0/3`,+ {+ signal: AbortSignal.timeout(requestTimeout)+ }+ )+ .then((res) => res.json())+ .then((jsonRes) => {+ if (+ jsonRes['results']?.['count'] === 1 ||+ jsonRes['results']?.['docs']?.[0]?.['ticker'] === symbol+ ) {+ return jsonRes['results']['docs'][0]['ticker'];+ }++ return undefined;+ })+ .catch(() => {+ return undefined;+ });+ }}