Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/remove deprecated firstOrderDate from portfolio performance endpoint response (#7483)

Thomas Kaul5e9ac0169e91
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8c47efb2e9..b80a682c42 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Harmonized the data format of the export functionality
+- Removed the deprecated `firstOrderDate` attribute from the `GET api/v2/portfolio/performance` endpoint response
- Improved the language localization for German (`de`)
- Upgraded `prisma` from version `7.8.0` to `7.9.1`
diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index d1aff38111..0a69cf32df 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -1035,7 +1035,6 @@ export class PortfolioService {
return {
chart: [],
dateOfFirstActivity: undefined,
- firstOrderDate: undefined,
hasErrors: false,
performance: {
currentNetWorth: 0,
@@ -1093,7 +1092,6 @@ export class PortfolioService {
errors,
hasErrors,
dateOfFirstActivity: parseDate(historicalData[0]?.date),
- firstOrderDate: parseDate(historicalData[0]?.date),
performance: {
netPerformance,
netPerformanceWithCurrencyEffect,
diff --git a/libs/common/src/lib/interfaces/responses/portfolio-performance-response.interface.ts b/libs/common/src/lib/interfaces/responses/portfolio-performance-response.interface.ts
index 104302de3d..8177bd533c 100644
--- a/libs/common/src/lib/interfaces/responses/portfolio-performance-response.interface.ts
+++ b/libs/common/src/lib/interfaces/responses/portfolio-performance-response.interface.ts
@@ -5,11 +5,5 @@ import { ResponseError } from './errors.interface';
export interface PortfolioPerformanceResponse extends ResponseError {
chart?: HistoricalDataItem[];
dateOfFirstActivity: Date;
-
- /**
- * @deprecated Use `dateOfFirstActivity` instead
- */
- firstOrderDate: Date;
-
performance: PortfolioPerformance;
}