Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/setup tests for valid and invalid import files (#8021)

Thomas Kaul5fac38c4d78e
diff --git a/apps/api/src/app/import/import-data.dto.spec.ts b/apps/api/src/app/import/import-data.dto.spec.ts
new file mode 100644
index 0000000000..b6cce2a739
--- /dev/null
+++ b/apps/api/src/app/import/import-data.dto.spec.ts
@@ -0,0 +1,73 @@
+import { BadRequestException, ValidationPipe } from '@nestjs/common';
+import { DataSource, Type } from '@prisma/client';
+import { readFileSync } from 'node:fs';
+import { join } from 'node:path';
+
+import { ImportDataDto } from './import-data.dto';
+
+const validationPipe = new ValidationPipe({
+ forbidNonWhitelisted: true,
+ transform: true,
+ whitelist: true
+});
+
+function loadImportData(directory: string, fileName: string): ImportDataDto {
+ const { accounts, activities, assetProfiles, platforms, tags } = JSON.parse(
+ readFileSync(
+ join(__dirname, '../../../../../test/import', directory, fileName),
+ 'utf8'
+ )
+ ) as ImportDataDto;
+
+ return { accounts, activities, assetProfiles, platforms, tags };
+}
+
+describe('ImportDataDto', () => {
+ it('accepts sample.json', async () => {
+ await expect(
+ validationPipe.transform(loadImportData('ok', 'sample.json'), {
+ metatype: ImportDataDto,
+ type: 'body'
+ })
+ ).resolves.toBeInstanceOf(ImportDataDto);
+ });
+
+ it.each([
+ {
+ fileName: 'invalid-data-source.json',
+ messages: [
+ `activities.0.dataSource must be one of the following values: ${Object.values(DataSource).join(', ')}`
+ ]
+ },
+ {
+ fileName: 'invalid-date-before-min.json',
+ messages: ['activities.0.date must be after 1970']
+ },
+ {
+ fileName: 'invalid-date.json',
+ messages: [
+ 'activities.0.date must be after 1970',
+ 'activities.0.date must be a valid ISO 8601 date string'
+ ]
+ },
+ {
+ fileName: 'invalid-type.json',
+ messages: [
+ `activities.0.type must be one of the following values: ${Object.values(Type).join(', ')}`
+ ]
+ }
+ ])('refuses $fileName', async ({ fileName, messages }) => {
+ const error: unknown = await validationPipe
+ .transform(loadImportData('not-ok', fileName), {
+ metatype: ImportDataDto,
+ type: 'body'
+ })
+ .catch((validationError: unknown) => validationError);
+
+ expect(error).toBeInstanceOf(BadRequestException);
+
+ expect((error as BadRequestException).getResponse()).toMatchObject({
+ message: messages
+ });
+ });
+});
diff --git a/apps/api/tsconfig.spec.json b/apps/api/tsconfig.spec.json
index e5f982722c..63aa6d4f95 100644
--- a/apps/api/tsconfig.spec.json
+++ b/apps/api/tsconfig.spec.json
@@ -2,6 +2,7 @@
"extends": "./tsconfig.json",
"compilerOptions": {
"outDir": "../../dist/out-tsc",
+ "target": "es2021",
"module": "preserve",
"types": ["jest", "node"]
},