Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/resolve no-constant-binary-expression ESLint rule (#5890)

Kenrick Tandrian60bfe1eaa6b0
diff --git a/eslint.config.cjs b/eslint.config.cjs
index cb586e8edd..a88d0cc858 100644
--- a/eslint.config.cjs
+++ b/eslint.config.cjs
@@ -152,7 +152,6 @@ module.exports = [
// The following rules are part of eslint:recommended
// and can be remove once solved
- 'no-constant-binary-expression': 'warn',
'no-loss-of-precision': 'warn',
// The following rules are part of @typescript-eslint/recommended-type-checked
diff --git a/libs/ui/src/lib/fire-calculator/fire-calculator.component.ts b/libs/ui/src/lib/fire-calculator/fire-calculator.component.ts
index df7ca79fad..44276ec43b 100644
--- a/libs/ui/src/lib/fire-calculator/fire-calculator.component.ts
+++ b/libs/ui/src/lib/fire-calculator/fire-calculator.component.ts
@@ -185,7 +185,7 @@ export class GfFireCalculatorComponent implements OnChanges, OnDestroy {
'principalInvestmentAmount'
).value,
projectedTotalAmount:
- Number(this.getProjectedTotalAmount().toFixed(0)) ?? 0,
+ Math.round(this.getProjectedTotalAmount()) || 0,
retirementDate:
this.getRetirementDate() ?? this.DEFAULT_RETIREMENT_DATE
},