Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Make NODE_ENV optional in production

Oleg Shvartsman62c93ad99dcb
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e2524f6d4e..9482e9f012 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Harmonized the axis style of charts
+- Made setting `NODE_ENV: production` optional (to avoid `ENOENT: no such file or directory` errors on startup)
- Removed the environment variable `ENABLE_FEATURE_CUSTOM_SYMBOLS`
## 1.242.0 - 2023-03-04
diff --git a/apps/api/src/app/frontend.middleware.ts b/apps/api/src/app/frontend.middleware.ts
index a43afa3f97..ea860b0e18 100644
--- a/apps/api/src/app/frontend.middleware.ts
+++ b/apps/api/src/app/frontend.middleware.ts
@@ -1,11 +1,11 @@
import * as fs from 'fs';
import * as path from 'path';
+import { environment } from '@ghostfolio/api/environments/environment';
import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
import { DEFAULT_LANGUAGE_CODE } from '@ghostfolio/common/config';
import { DATE_FORMAT } from '@ghostfolio/common/helper';
import { Injectable, NestMiddleware } from '@nestjs/common';
-import { ConfigService } from '@nestjs/config';
import { format } from 'date-fns';
import { NextFunction, Request, Response } from 'express';
@@ -18,18 +18,10 @@ export class FrontendMiddleware implements NestMiddleware {
public indexHtmlIt = '';
public indexHtmlNl = '';
public indexHtmlPt = '';
- public isProduction: boolean;
public constructor(
- private readonly configService: ConfigService,
private readonly configurationService: ConfigurationService
) {
- const NODE_ENV =
- this.configService.get<'development' | 'production'>('NODE_ENV') ??
- 'development';
-
- this.isProduction = NODE_ENV === 'production';
-
try {
this.indexHtmlDe = fs.readFileSync(
this.getPathOfIndexHtmlFile('de'),
@@ -100,7 +92,7 @@ export class FrontendMiddleware implements NestMiddleware {
if (
request.path.startsWith('/api/') ||
this.isFileRequest(request.url) ||
- !this.isProduction
+ !environment.production
) {
// Skip
next();
diff --git a/apps/api/src/main.ts b/apps/api/src/main.ts
index e53ade52cc..6def14ad02 100644
--- a/apps/api/src/main.ts
+++ b/apps/api/src/main.ts
@@ -10,15 +10,10 @@ async function bootstrap() {
const configApp = await NestFactory.create(AppModule);
const configService = configApp.get<ConfigService>(ConfigService);
- const NODE_ENV =
- configService.get<'development' | 'production'>('NODE_ENV') ??
- 'development';
-
const app = await NestFactory.create(AppModule, {
- logger:
- NODE_ENV === 'production'
- ? ['error', 'log', 'warn']
- : ['debug', 'error', 'log', 'verbose', 'warn']
+ logger: environment.production
+ ? ['error', 'log', 'warn']
+ : ['debug', 'error', 'log', 'verbose', 'warn']
});
app.enableCors();
app.enableVersioning({