Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Bugfix/allocate remaining percentage to unknown data in portfolio proportion chart (#6054)
David Requeno646ee7271a27
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 7ceb94a114..f86d7c01ab 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0- Moved the notification module to `@ghostfolio/ui`- Improved the language localization for German (`de`)+### Fixed++- Fixed a calculation issue that resulted in the incorrect assignment of unknown data in the portfolio proportion chart component+## 2.222.0 - 2025-12-07### Addeddiff --git a/libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts b/libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.tsindex 2d8a03ac08..fb11897ebc 100644--- a/libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts+++ b/libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts@@ -1,6 +1,6 @@import { getTooltipOptions } from '@ghostfolio/common/chart-helper';import { UNKNOWN_KEY } from '@ghostfolio/common/config';-import { getLocale, getTextColor } from '@ghostfolio/common/helper';+import { getLocale, getSum, getTextColor } from '@ghostfolio/common/helper';import {AssetProfileIdentifier,PortfolioPosition@@ -193,6 +193,30 @@ export class GfPortfolioProportionChartComponent});}+ if (this.isInPercent) {+ const totalValueInPercentage = getSum(+ Object.values(chartData).map(({ value }) => {+ return value;+ })+ );++ const unknownValueInPercentage = new Big(1).minus(totalValueInPercentage);++ if (unknownValueInPercentage.gt(0)) {+ // If total is below 100%, allocate the remaining percentage to UNKNOWN_KEY+ if (chartData[UNKNOWN_KEY]) {+ chartData[UNKNOWN_KEY].value = chartData[UNKNOWN_KEY].value.plus(+ unknownValueInPercentage+ );+ } else {+ chartData[UNKNOWN_KEY] = {+ name: UNKNOWN_KEY,+ value: unknownValueInPercentage+ };+ }+ }+ }+let chartDataSorted = Object.entries(chartData).sort((a, b) => {return a[1].value.minus(b[1].value).toNumber();