Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Task/eliminate OnDestroy lifecycle hook from home summary component (#6550)
Erwin6a714687b54e
diff --git a/apps/client/src/app/components/home-summary/home-summary.component.ts b/apps/client/src/app/components/home-summary/home-summary.component.tsindex 454d056892..719cfbd29a 100644--- a/apps/client/src/app/components/home-summary/home-summary.component.ts+++ b/apps/client/src/app/components/home-summary/home-summary.component.ts@@ -13,14 +13,13 @@ import {ChangeDetectorRef,Component,CUSTOM_ELEMENTS_SCHEMA,- OnDestroy,+ DestroyRef,OnInit} from '@angular/core';+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';import { MatCardModule } from '@angular/material/card';import { MatSnackBarRef, TextOnlySnackBar } from '@angular/material/snack-bar';import { DeviceDetectorService } from 'ngx-device-detector';-import { Subject } from 'rxjs';-import { takeUntil } from 'rxjs/operators';@Component({imports: [GfPortfolioSummaryComponent, MatCardModule],@@ -29,7 +28,7 @@ import { takeUntil } from 'rxjs/operators';styleUrls: ['./home-summary.scss'],templateUrl: './home-summary.html'})-export class GfHomeSummaryComponent implements OnDestroy, OnInit {+export class GfHomeSummaryComponent implements OnInit {public deviceType: string;public hasImpersonationId: boolean;public hasPermissionForSubscription: boolean;@@ -40,11 +39,10 @@ export class GfHomeSummaryComponent implements OnDestroy, OnInit {public summary: PortfolioSummary;public user: User;- private unsubscribeSubject = new Subject<void>();-public constructor(private changeDetectorRef: ChangeDetectorRef,private dataService: DataService,+ private destroyRef: DestroyRef,private deviceService: DeviceDetectorService,private impersonationStorageService: ImpersonationStorageService,private userService: UserService@@ -57,7 +55,7 @@ export class GfHomeSummaryComponent implements OnDestroy, OnInit {);this.userService.stateChanged- .pipe(takeUntil(this.unsubscribeSubject))+ .pipe(takeUntilDestroyed(this.destroyRef)).subscribe((state) => {if (state?.user) {this.user = state.user;@@ -77,7 +75,7 @@ export class GfHomeSummaryComponent implements OnDestroy, OnInit {this.impersonationStorageService.onChangeHasImpersonation()- .pipe(takeUntil(this.unsubscribeSubject))+ .pipe(takeUntilDestroyed(this.destroyRef)).subscribe((impersonationId) => {this.hasImpersonationId = !!impersonationId;});@@ -86,11 +84,11 @@ export class GfHomeSummaryComponent implements OnDestroy, OnInit {public onChangeEmergencyFund(emergencyFund: number) {this.dataService.putUserSetting({ emergencyFund })- .pipe(takeUntil(this.unsubscribeSubject))+ .pipe(takeUntilDestroyed(this.destroyRef)).subscribe(() => {this.userService.get(true)- .pipe(takeUntil(this.unsubscribeSubject))+ .pipe(takeUntilDestroyed(this.destroyRef)).subscribe((user) => {this.user = user;@@ -99,17 +97,12 @@ export class GfHomeSummaryComponent implements OnDestroy, OnInit {});}- public ngOnDestroy() {- this.unsubscribeSubject.next();- this.unsubscribeSubject.complete();- }-private update() {this.isLoading = true;this.dataService.fetchPortfolioDetails()- .pipe(takeUntil(this.unsubscribeSubject))+ .pipe(takeUntilDestroyed(this.destroyRef)).subscribe(({ summary }) => {this.summary = summary;this.isLoading = false;